Needs work
Project:
Drupal core
Version:
main
Component:
image system
Priority:
Normal
Category:
Feature request
Assigned:
Unassigned
Issue tags:
Reporter:
Created:
12 Mar 2011 at 13:49 UTC
Updated:
13 Feb 2024 at 05:59 UTC
Jump to comment: Most recent, Most recent file
Comments
Comment #1
naught101 commentedsub, I will try to make a patch for this when I get time.
Comment #2
decibel.places commented"List styling option" as a title sounds like add an option to style the images in a list.
Since I dutifully searched before duplicating the request to add the actual effect to the admin page at admin/config/media/image-styles - and I luckily read this issue - I am respectfully changing the title in hope that it is clearer.
Comment #3
naught101 commentedHow about some of this?
Comment #4
naught101 commentedMoving to 8.x, since I guess this isn't going to get in to D7 any time soon.
Comment #5
naught101 commentedComment #6
donutdan4114 commentedFor D7, not sure why double values are shown, but it is confusing.
Comment #7
naught101 commenteddonutdan4114: try removing the . from the .=, that should fix it, although I'm not sure what the proper behaviour should be there.
Comment #8
donutdan4114 commentedSome changes that make the image styles more clear.
Comment #9
donutdan4114 commentedThe version with a separate column is nice, but with everything just on one line, becomes hard to read:

My suggestion is that each "effect" goes on a new line, easier to read that way.
Comment #10
naught101 commentedTagging
The last style in your example could get quite high with one effect per line.
Comment #11
Bojhan commentedI am not sure about this idea. When you have a bunch, finding the distinction from the details is very hard. Ideally the title should be informative enough.
Comment #12
naught101 commentedI think it would be rare to run more than a 3-5 filters on an image. Even some stupid fancy ye-olde polaroid-style is only going to have a few (trim and resize; colour filter, add noise, add frame, rotate, dropshadow).
For most general use styles, the really important thing to note is the final image size. The default styles have this in the style name, which is redundant information, but currently necessary, because the effects aren't listed (unfortunately, these patches won't help in other places where it would be good to know sizes, like in the Media module's image adder).
Comment #13
yoroy commentedI know I add dimensions to the style name itself. It's the most important bit of extra info and you can fit it into the title. All the other ones are a bit too much for this level in the information architecture.
Comment #14
alansaviolobo commentedreroll
Comment #17
wturrell commentedUnassigning due to passage of time (see Assigning Ownership)
Comment #18
wturrell commented- Patch no longer applies in 8.2.x.
- Converted issue summary to template
- Edited problem statement including referring to the D8 rather D7 URL
Comment #19
jofitzReroll.
Comment #21
wturrell commentedPatch applies successfully to 8.3.x, and works.
If we're going to display options, it's not very useful to show those that aren't selected.
We could do better than "1' for those which are turned on, e.g. "allow upscaling" or "upscaling" rather than "upscale: 1".
We could also convert "width: 480, height: 480" to 480x480, though (as mentioned in #12) note with a default install the dimensions are in the style name anyway, which I suspect encourages people to add them for any new styles they create.
Note the Edit page does some of this already, e.g. /admin/config/media/image-styles/manage/medium shows:
Meanwhile here's a screenshot with the patch, where we have two image styles, "allow upscaling" checked on the second.
Personally, I think I'd scrap the options and just list effect names for simplicity, so just "image_scale" (or better, "scale"). If you need more detail you're only a click away.
Comment #22
yoroy commentedI wonder who *doesn't* use the dimensions as (part of) the style name :) Are we really that interested in all the other possible effects? I worry we're front-loading too much information, cluttering the list with relatively cryptic textual information that will be much clearer to understand by seeing the actual demo that is one click away.
Comment #35
candelas commentedCan someone make a patch for Drupal 11 and 10.
This is a very good help when you have many styles.
Thanks :)