I installed 7.x-1.0. The "Exclude title from display" checkbox shows up in the node edit page, but has no effect. I checked the box for the Basic Page item which makes up my home page, and I still see the title. No change if I log out; I see the node title even as anonymous.

CommentFileSizeAuthor
#8 exclude_node_title-7.x-1.x-dev-menu-modesty.patch531 bytesRory
#9 Screenshot.png33.77 KBgabrielu

Comments

gabrielu’s picture

gabrielu commented

Maybe it's related to this? http://drupal.org/node/1072208#comment-4136461 have you tried this?

roy smith’s picture

roy smith commented

Doesn't seem to be related. I made the following change, with no effect. The title is still showing.

--- exclude_node_title.module~	2011-03-12 10:00:22.000000000 -0800
+++ exclude_node_title.module	2011-03-12 13:03:07.000000000 -0800
@@ -76,7 +76,7 @@
 /**
  * Implements hook_node_view()
  */ 
-function exclude_node_title_node_view($node, $view_mode, $langcode) {
+function exclude_node_title_node_view($node, $view_mode) {
   if (variable_get('exclude_node_title_remove_title', 0) == 1 && user_access('use exclude node title')) {
     if (in_array($node->nid, variable_get('exclude_node_title_nid_list', array()))) {
       $node->title = '';
roy smith’s picture

roy smith commented

Dooh! I think I've got it figured out now. If you go to admin/config/content/exclude_node_title, and check "Remove node title from teasers too", it works. Some comments:

1) I didn't realize that basic pages even had a teaser view; I thought that only applied to articles. But I may just be showing my lack of any deep drupal-fu by saying that :-)

2) I didn't realize there was a configuration screen for this module. Normally, modules that you can configure have a "configure" link right on the Modules page. Had there been such a link, I'm sure I would have clicked it as soon as I enabled the module and discovered that this option exists.

3) It looks like checking the basic page box under "EXCLUDE TITLE BY CONTENT-TYPE" turned off title display for ALL nodes of that type. The config page should clarify that this is what it's doing.

roy smith’s picture

roy smith commented

PS -- other than the above, this is a nice little tool. Thanks for writing it.

gabrielu’s picture

gabrielu commented
Status: Active » Needs work

2) I didn't realize there was a configuration screen for this module. Normally, modules that you can configure have a "configure" link right on the Modules page. Had there been such a link, I'm sure I would have clicked it as soon as I enabled the module and discovered that this option exists.
is Solved, I added the configuration link, check latest DEV release.

For the other points you are right, we should add more descriptive information to the Configuration page.
Also, for usability, I believe is best to add a option where you can select on wich Content-types the field should appear, because for now it appears on each node/edit form on your site.

Gabriel

gabrielu’s picture

gabrielu commented
Title: Not working on D7 » UX Improvments
Version: 7.x-1.0 » 7.x-1.x-dev
Component: Miscellaneous » User interface
Category: bug » feature
gabrielu’s picture

gabrielu commented
Status: Needs work » Needs review

Check the new settings page in version 7.x-1.4

Rory’s picture

Rory commented
Status: Reviewed & tested by the community » Needs review
StatusFileSize
new exclude_node_title-7.x-1.x-dev-menu-modesty.patch531 bytes

The following patch keeps the "configure" link for the module but does away with the Configuration menu item.

Always pleased when a module is modest enough to not place a link to a settings page under the Configuration menu unless the link will be used very frequently.

gabrielu’s picture

gabrielu commented
StatusFileSize
new Screenshot.png33.77 KB

Hi,
I am a very big fan of the Administration menu, this means that the configuration items will not appear in the admin menu?

Thanks,
Gabriel

gabrielu’s picture

gabrielu commented
Status: Needs review » Reviewed & tested by the community

Just tested,
It works fine, applied your patch, thanks.

Gabriel

wranvaud’s picture

wranvaud commented
Status: Needs review » Reviewed & tested by the community

I had a hard time to find everything that needs to be configured. At last i did it but I was missing the fact that permissions to "use exclude node title" had to be checked for all roles for it to work.

I'd suggest to put these instructions on the project page together with the full view, teaser etc...

fizk’s picture

fizk commented
Status: Reviewed & tested by the community » Closed (fixed)

Sorry, but too many people, including myself, are reporting that they are expecting a visible menu item in the admin configuration page. I'm going to revert this commit:

http://drupalcode.org/project/exclude_node_title.git/commit/ebd97c222e9b...

An alternative solution is to install the Menu Modesty module.

  • Commit ebd97c2 on 7.x-1.x, 8.x-1.x authored by Rory, committed by gabrielu: 
    Defined admin menu as MENU_LOCAL_TASK (see #1090474)