provide a CTools plugin to display adsense_managed content. Patch will follow.

CommentFileSizeAuthor
#3 adsense-panels.png32.34 KBamitaibu
#2 1091008-adsense-ctools-plugin-2.patch4.43 KBamitaibu
#1 1091008-adsense-ctools-plugin.patch3.18 KBamitaibu

Comments

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Active » Needs work
StatusFileSize
new 1091008-adsense-ctools-plugin.patch3.18 KB

Still untested (I'm waiting for my AdSense account).

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
Status: Needs work » Needs review
StatusFileSize
new 1091008-adsense-ctools-plugin-2.patch4.43 KB

Ok, it was working :)
I've cleaned up the code, so there is no duplication of the form between the block configuration and pane configuration.

amitaibu’s picture

amitaibu
Primary language Hebrew
Location Israel
commented
StatusFileSize
new adsense-panels.png32.34 KB

Oh, and here's a screenshot of how it looks.

szantog’s picture

szantog commented

I applied it manually against the latest, because I get:

: curl http://drupal.org/files/issues/1091008-adsense-ctools-plugin-2.patch | git apply
  % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current                                                                                             
                                 Dload  Upload   Total   Spent    Left  Speed                                                                                               
100  4537  100  4537    0     0   7837      0 --:--:-- --:--:-- --:--:-- 11784
error: adsense_managed.module: No such file or directory
<stdin>:144: new blank line at EOF.
+

It seems to be fine, I get the content type in the pane edit add content pane form, there is a Google adsense slot as well, but when I clicked it, I get this #1765588: Can't add block to panel.

jcnventura’s picture

jcnventura
Primary language English
commented
Status: Needs review » Closed (won't fix)

This won't happen for now.