While not strictly necessary, I think it's preferred to use db_placeholders instead of implode(', ', ...) when constructing queries that contain lists, and it comes with the added benefit of type-checking.

CommentFileSizeAuthor
#2 db_placeholders.patch2.75 KBmr.baileys
db_placeholders.patch1.62 KBmr.baileys

Comments

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Needs review » Needs work

Doesn't work, will upload a better patch in a sec.

mr.baileys’s picture

mr.baileys
Primary language Dutch
Location 🇧🇪 (Ghent)
commented
Status: Needs work » Needs review
StatusFileSize
new db_placeholders.patch2.75 KB

This one should work.

matt2000’s picture

matt2000 commented
Status: Needs review » Fixed

Thanks!

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

  • Commit c5bf7d3 on 6.x-1.x, 7.x-1.x by matt2000: 
    #1091012 by mr.baileys: Fixed Use db_placeholders() instead of implode.