Requirements warning in Drupal creates a Critical warning in Nagios

Slightly revised patch - the above was making drush make error out. This one makes drush make happy. =)

Ok, Khalid has very kindly made me co-maintainer so we can push this along a little. I'm setting this back to "needs work", because we're changing the expected Nagios codes. While this would be safe for new installs, we need to consider the possibility people are already running with modified Nagios codes to match the ones in the module. So, with that in mind, this patch needs to be a little more complex:

1. I need to roll some sort of beta release of the current Drupal 6 module (I think that's safe - we've verified it works fine)

2. This patch needs to *assume* people have set up Nagios to work with the old version and provide an upgrade path and a UI for mapping the codes (e.g. the errors need to be variables, not constants, there should be a UI for changing them and hook_update_N() needs to set the variables to the old values so there will be no interuption in service as a result of an upgrade, unless people have hacked the current module, in which case they're on their own!)

Edit: Obviously the patch needs re-rolling *after* the beta1 release, otherwise an upgrade path would be meaningless, so let's park this for a week or two.

It's a bit more work, but given the nature of the module and the sort of people most likely to be using it, we need to tread particularly carefully here. This needs to be rock solid. =)

Assigning to *me*.

Bumping myself! *sigh*

Have moved the defined values to variables, created the upgrade path and set the defaults according to mig5's patch in #1 - still needs a UI, but the upgrade path means this can be safely committed and advanced users can massage the variables with drush:

// Defines to be used by this module and others that use its hook_nagios().
define('NAGIOS_STATUS_OK',       variable_get('nagios_status_ok_value', 0));
define('NAGIOS_STATUS_WARNING',  variable_get('nagios_status_warning_value', 1));
define('NAGIOS_STATUS_CRITICAL', variable_get('nagios_status_critical_value', 2));
define('NAGIOS_STATUS_UNKNOWN',  variable_get('nagios_status_unknown_value', 3));

Finally committed the last change, the admin UI. Yay!

Actually, not closed - to be ported to D7.

Committed to D7.

Just update the module, the fix is in.