Here it is, the dreaded D7 feature request... ;-)

CommentFileSizeAuthor
#12 nagios-d7upgrade-1091318-12.patch23.12 KBraystuart
#8 nagios-d7upgrade-1091318-8.patch23.45 KBraystuart

Comments

bstanfield’s picture

bstanfield commented

subscribe

gadams’s picture

gadams commented

subscribing

basicmagic.net’s picture

basicmagic.net commented

subscribe

Berromator Technologies’s picture

Berromator Technologies commented

subscribe

helmo’s picture

helmo commented

subscribe

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Status: Active » Postponed

Depends upon:
http://drupal.org/node/796864#comment-4280640

Will set back to active once the Drupal 6.x-1.0 release is out of the door. In the mean time, patches welcome!

aethiolas’s picture

aethiolas commented

sub

raystuart’s picture

raystuart commented
StatusFileSize
new nagios-d7upgrade-1091318-8.patch23.45 KB

Here is a patch that at least seems to be working for me on D7. The bulk of the changes are coming from Coder Upgrade. Then, nagios_status_page() required a change re http://drupal.org/node/224333#theme_page. After that, I made modifications to nagios_check_session_anon() and nagios_check_session_auth(), since it looks like sess_count() is no longer available in D7 - http://drupal.org/node/655212#comment-2365590.

I haven't yet looked at any of the other nagios_check_* functions, since they seem to be working. I did enable an older version of a module as a test, and nagios did issue a warning and listed the module as NOT CURRENT.

Haven't tried anything with nrpe, but each of the drush nagios commands seemed to return correct numbers on a pretty bare-bones site.

helmo’s picture

helmo commented
Status: Postponed » Needs review
greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Oh, very cool - thanks for pushing this along! Does anyone else have a D7 Nagios set-up to test this? I can probably sort something out next month, but if we get some community reviews ahead of that then maybe we can get a 7.x-1.x-dev up faster. =)

In fact, I'm inclined to just use this, if I get chance to give it a quick once-over.

helmo’s picture

helmo commented

The patch seems OK.

It works so far, both via http and drush

raystuart’s picture

raystuart commented
StatusFileSize
new nagios-d7upgrade-1091318-12.patch23.12 KB

It's still working fine for me, but I'm attaching another patch. Also, I'd forgotten to mention this change above.

The original admin page was at admin/config/nagios. In the first patch, I'd put it at admin/config/monitoring/nagios and created a Monitoring section at admin/config/monitoring. In this patch, I put the admin page at admin/config/system/nagios so it shows up alongside cron, site info, and such. That should be a better place for it, no?

nmcclain’s picture

nmcclain commented
Status: Needs review » Reviewed & tested by the community

I am using this in production and it's working great. I ran it through Coder and there were only a few minor warnings -- I'd love to see this as a dev release.

Thank you to raystuart and greg.harvey!!

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented

Don't thank me, it's all raystuart. Will try to remember to roll a dev snapshot tomorrow. Thanks for the feedback!

coderintherye’s picture

coderintherye commented

I can confirm this is working. Much thanks raystuart.

A note to anyone who downloads 6.x-1.x and then applies this patch, make sure to also remove the extra lines that drupal.org adds to the tarball download: 

; Information added by drupal.org packaging script on 2011-04-14
version = "6.x-1.0-beta1"
core = "6.x"
project = "nagios"
datestamp = "1302812816"

Would be great to see this up as an actual release.

greg.harvey’s picture

greg.harvey
Primary language English
Location Occitanie, France
commented
Version: 6.x-1.x-dev » 7.x-1.x-dev
Status: Reviewed & tested by the community » Fixed

Drupal 7 dev snapshot rolled. It will be available shortly. We'll let that roll for a while and if no one has any problems it can go beta1 like the Drupal 6 release.

coderintherye’s picture

coderintherye commented

Awesome, thanks both :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.