Posted by johnbarclay on March 14, 2011 at 4:32am
3 followers
| Project: | Accessible Helper Module |
| Version: | 7.x-2.x-dev |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Issue Summary
#331893: Add colouring (and description) to password checker
Comments
#1
#2
This is a good start for implementations until D8 - http://drupal.org/node/331893#comment-4607980
#3
I made a patch that edits the user.js file. It needs some work in the admin file. Also, when I got the most recent version from git, made a new test branch and switched back to the 7.x-2.x branch, I got the warning that 7.x-2.x was ambiguous. I didn't realize this when I made the patch, but the patch only works on the ambiguous 7.x-2.x. I guess the structure changed a bit and I have to fix the user.admin.inc as the checkbox/descriptions don't show up in the config tab. Anyway, this will work as a first step.
Edit: It does work on the current version but there is no options to turn it off (or on) yet. Also, in the patch, user-permissions.js is not needed.
#4
Great.
Not sure whats whats ambiguous; there should be no conflict with those files. I'm guessing the conflict was because I had checked in some code this afternoon. Perhaps check out a new copy per http://drupal.org/node/365160/git-instructions/7.x-2.x throw the files in and make the patch. Do you want to be a committer? That will allow you to commit your own patches.
Also, when you start on a task assign it to yourself in the issue. I doubt there will be much conflict, but its good to be safe.
I think it might be better if the .js file wasn't in a subfolder.
#5
I wouldn't mind being a committer.I fixed the patch a bit so it is neater. A js folder might be a good idea if there is a lot of .js files down the road. It would keep the structure tidy but I switched it out for this patch.
#6
I added you as a committer. I'm indifferent about subcontent folder structure including javascript. I just prefer its consistent.