Closed (fixed)
Project:
Blockify
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
14 Mar 2011 at 12:15 UTC
Updated:
30 Mar 2011 at 07:21 UTC
119 $user = user_load($node->uid);
120 return theme('blockify_node', $user, $node);
Potential security risk to say $user when you don't mean the global $user. It's good code style to say $author instead. The theme function should be changed too.
Comments
Comment #1
psynaptic commentedSure, or $account. No patch? Shame on you.
Comment #2
psynaptic commentedCommitted as $account to 6.x-1.x.
Comment #3
joachim commented> No patch? Shame on you.
I was at work, and took a quick look at this because it *might* be useful in due course...