When installing the module with Fbconnect at the same time, I've got error:

Fatal error: Call to undefined function libraries_get_path() in openid_selector/openid_selector.install on line 13
CommentFileSizeAuthor
#9 openid_selector-1092262-librarians_get_preg_syntax.patch1.77 KBxurizaemon
#8 openid_selector-1092262-librarians_get_path.patch1.7 KBxurizaemon

Comments

andriy_gerasika’s picture

andriy_gerasika commented
Status: Active » Postponed (maintainer needs more info)

do you install using install profiles? I suspect this error might be related to
http://drupal.org/node/1064298

kenorb’s picture

kenorb commented

No, it was simply enabled from admin/build/modules
I think you shouldn't use any of module function which haven't been activated yet and it happen very often with Drupal when you activating depending modules at once.
It's kind of Drupal bug, but it never was fixed.
Could be related to: #389126: system_modules_submit() disable only the module whose hook_requirements() returns an error, not the modules depending from it

kenorb’s picture

kenorb commented
Status: Postponed (maintainer needs more info) » Active
sylv3st3r’s picture

sylv3st3r commented

I can confirm that this happen to latest D7 version.
Fresh download Libraries and this module. Active both modules at the same time. And boom.

lee20’s picture

lee20 commented

Same problem occurred with 6.x-1.5 when trying to enable both modules at the same time using Drush. Easy workaround to get up and running is to enable libraries, then enable openid_selector (in case that wasn't already obvious).

andriy_gerasika’s picture

andriy_gerasika commented
Status: Active » Fixed

fixed in Drupal 6 & Drupal 7 -dev versions (dev version downloads will be refreshed in 12 hours)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Closed (fixed) » Needs review
StatusFileSize
new openid_selector-1092262-librarians_get_path.patch1.7 KB

46aa8256bd8459538889ad14da60d6a3f306e9e9 didn't fix this ... How about this?

Duplicated by #1241040: Fatal error: Call to undefined function libraries_get_path().

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
StatusFileSize
new openid_selector-1092262-librarians_get_preg_syntax.patch1.77 KB

Updating patch above to roll in #1673186: Correct drupal_system_listing() $mask param for D7 preg_match() because I am too lazy to manage conflicting patch streams for one-liners while we wait for a reply on #1673150: Is OpenID Selector still being maintained?.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented
Status: Needs review » Needs work

Patch above is bung, it checks the function exists then tries to include_once libraries.module anyway. Apparently I was confused.

On reflection, rather than duplicating libraries module functionality for hook_enable(), shouldn't we just make the JS library check a bit more re-useable, check it in hook_requirements() and on config page, and be done with it?

If this goes from hook_enable() then the problem is solved. If we need Drupal to load depended modules reliably for use in hook_enable() then that's not OpenID Selector's problem (which I think kenorb is alluding to).

andriy_gerasika’s picture

andriy_gerasika commented
Version: 6.x-1.5 » 7.x-1.x-dev
Status: Needs work » Fixed

fixed in http://drupalcode.org/project/openid_selector.git/commit/1ae4acc

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.