In the banner "Statistics" table, the "Status" for "This week" always reports "disabled".
This is due to falling-through in the following switch statement in function _banner_view_statistics()
switch($node->workflow) {
case BANNER_PENDING:
$status = t('pending');
case BANNER_ENABLED:
case BANNER_DAY_LIMIT:
$status = t('enabled');
default:
$status = t('disabled');
}
This will always fall through to the last statement, because the "break"s are missing.
I've fixed and tested this on 4.7, and re-rolled the patch to HEAD (attached).
Best wishes, Mark.
| Comment | File | Size | Author |
|---|---|---|---|
| #1 | banner.module.4-7.weekly.patch | 647 bytes | plumbley |
| banner.module.HEAD.weekly.patch | 635 bytes | plumbley |
Comments
Comment #1
plumbley commentedHere is the patch for 4.7.
Comment #2
wulff commentedWill be fixed in next commit. Thanks.
Comment #3
(not verified) commented