In the banner "Statistics" table, the "Status" for "This week" always reports "disabled".

This is due to falling-through in the following switch statement in function _banner_view_statistics()

  switch($node->workflow) {
    case BANNER_PENDING:
      $status = t('pending');
    case BANNER_ENABLED:
    case BANNER_DAY_LIMIT:
      $status = t('enabled');
    default:
      $status = t('disabled');
  }

This will always fall through to the last statement, because the "break"s are missing.

I've fixed and tested this on 4.7, and re-rolled the patch to HEAD (attached).

Best wishes, Mark.

Comments

plumbley’s picture

StatusFileSize
new647 bytes

Here is the patch for 4.7.

wulff’s picture

Status: Needs review » Fixed

Will be fixed in next commit. Thanks.

Anonymous’s picture

Status: Fixed » Closed (fixed)