[D6] HD FLV Player

Hi, I am Rubén and I will review your full project application.

First of all I have noticed that your project file names hdflvplayer didn't fix with the project name hd_flv_player. This will be confuse for example when enabling the module with Drush.

Could you rename the project or the files, please?

Also you must install the Coder module and review your code. It has 7 critical warnings that should be solved.

Kind regards.

I have taken a brief look through the module for review and found several issues.

• hdflvplayer_display_main adds jQuery JavaScript; however, Drupal comes with jQuery.
• ajaxupload.3.5.js and swfobject.js are under the MIT license, but only GPL-licensed 3rd-party libraries are permitted on drupal.org.
• You create database queries by substituting variables directly into the SQL string in several places. No matter how careful you are, this still opens you up to SQL injection vulnerabilities. Use db_query's automatic escaping.
• Drupal modules should indent by 2 spaces, not 4.
• Inside hdflvplayer_display_main, there are several places (e.g. line 479) where text is hardcoded into HTML strings rather than being passed through t() first.
• hdflvplayer_addads_form also hardcodes various text, and incorrectly adds form elements by raw HTML rather than using the forms API. (For example, the forms API should be used to create the hidden form fields, rather than raw HTML.)
• hdflvplayer_ads_form should use Drupal's built-in table themeing rather than building its table from scratch.
• email.php is copied from an online tutorial without attribution, and could easily be used by a malicious attacker to send spam mail from your server. You should use a more careful method using drupal_mail.

But most importantly: how does your module differ from others, like VideoJS, JW Player, Media Player, MediaFront, or any of the many other Drupal media players? Generally, the Drupal community prefers collaboration over competition, and if your features could be better used as a contribution to an existing module, that would be preferable.

Once you've addressed these issues, you can set the status back to "needs review" and someone will take a look, but please do consider the module duplication question carefully.

No activity in several months. Reopen and set the status to "needs review" if you are still pursuing this application.