Hello

I am testing drupal 7 with french language, and there's a little charset problem with Administration menu when using apache with a default charset not set to UTF-8 : menu items are not displaying properly when loaded via ajax, in this case charset is set by apache.

Since it is common to set a default charset with apache, admin_menu_js_cache function should send Content-type header with correct charset.

CommentFileSizeAuthor
#1 issue-1092970-1.patch329 byteshansfn
Support from Acquia helps fund testing for Drupal Acquia logo

Comments

hansfn’s picture

Priority: Minor » Major
FileSize
329 bytes

I can report the same problem using Norwegian Bokmål. Since the menu items get almost unreadable, I have bumped the priority to major. I have attached the trivial patch too. (You could consider using drupal_add_http_header in stead of calling header directly, but I'm not sure you gain anything in this case.)

sun’s picture

sun’s picture

madar’s picture

I have the same problem. Apply patch #1 is solve the problem for me.
Thanks!

hansfn’s picture

Status: Active » Reviewed & tested by the community

Thx for the feedback. Setting status to tested.

PS! I wonder why this trivial patch hasn't been commited? It fixes a real issue and has no side-effects. Are we waiting for a fixing in core making the change unnecessary? (I checked the 7.x dev release - sorry, if this has been commited in git.)

Status: Reviewed & tested by the community » Needs work
Issue tags: -D7 stable release blocker

The last submitted patch, issue-1092970-1.patch, failed testing.

hansfn’s picture

Status: Needs work » Needs review

#1: issue-1092970-1.patch queued for re-testing.

Status: Needs review » Needs work
Issue tags: +D7 stable release blocker

The last submitted patch, issue-1092970-1.patch, failed testing.

gardy’s picture

Just insert this line to admin_menu.module at line 304, just below the other header settings:

drupal_add_http_header('Content-Type', 'text/csv; utf-8');

This solved the problem for me.

co_mete’s picture

Thanks it worked fine for me.

checker’s picture

I have a default_charset = iso-8859-1 and need this patch to make admin_menu useable for me.

sun’s picture

Anybody’s picture

Would be great if this can finally be fixed. It's still not working since month.

Regarding the comment above. Why "text/csv" and not "text/html"? Can somebody explain? Aren't we handling HTML content here?

sun’s picture

Status: Needs work » Fixed

Thanks for reporting, reviewing, and testing! Committed to all branches.

A new development snapshot will be available within the next 12 hours. This improvement will be available in the next official release.

Status: Fixed » Closed (fixed)
Issue tags: -D7 stable release blocker

Automatically closed -- issue fixed for 2 weeks with no activity.