Feedparser Compatibility
NathanRAFT - January 14, 2007 - 19:30
| Project: | News Page |
| Version: | 5.x-1.1 |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | postponed (maintainer needs more info) |
Description
This is a great module! I have used it in the past but given the limitations with the aggregator I stopped. Seeing that it is back in active developement is really exciting. Enabling filtered displays of feeds makes a ton of sense for many sites.
Feedparser is quickly becoming a replacement for both the core aggregator as well for aggregator 2. How about making this compatible with Feedparser so that standard taxonomy can be used?
#1
If this feature request is moved on it would be good to be able to choose from more than one category.
#2
Here is a patch that allows the news_page module to be used with feedpaser module. It will pull items from all feedparser feeds that produce normal (non-node) items.
#3
setting status to patch-needs review
#4
By "non-node items" do you mean Aggregator items as the processor? Feedparser only works with the nodes processor . I did not catch this until I applied the patch and tried it and saw that nothing is shows in a news page. It does allow for choosing of the feed now though.
Can you give me a little more info on how you tested this?
thanks!
#5
I'm not sure what you men when you say..
The "aggregator items" processor (in feedparser) works fine for me.
#6
Is there a way to alter this to be compatible with the aggregator_node as apposed to an aggregator_item?
$filter_query =
"SELECT i.*, f.link AS flink, f.title AS ftitle
FROM {aggregator_item} i
LEFT JOIN {aggregator_feed} f
ON i.fid = f.fid
LEFT JOIN {aggregator_category_feed} c
ON c.fid = f.fid
WHERE c.cid = '$cid'
AND ( $news_query )
ORDER BY timestamp DESC";
return $filter_query;
#7
Something must be wrong with my install. I can not get the Aggregator-items processor to work.
I will try it on a fresh install and see if it works. Thanks.. Hopefully I will be able to get it to work and will be able to use your patch!
I would also like a way to use nodes...will give it another try.. if you have any ideas please let me know!
#8
Yeah, I thought about this. I mean ideally the news page would work for both aggregator node and aggregator item types but there are at least two issues. One is that this one query will need to be much more complex as it would have to pull BOTH items and nodes if they are there. The next problem is that there is other code that looks for specifc fields coming from aggregator items. That code will fail if the item is actually a node as the field names are not the same. I don't think this is an easy problem to solve because you really dont know whether you'r going to get nodes or items when you setup a new news page. Also, I thought about specifying which type you wanted when you create the news page but right now the feedparser stores the processor type in a serialized value which means you can't join or select on the value.
My approach to this was to let news pages work as normal as long as the feedparser feed was generating normal items and not nodes. In the case of feedparser generating nodes I have a slightly different need and approach (http://drupal.org/node/123677) Basically this set of patches controls the promotion of feedparser nodes depending on whats defined in the news page.
#9
Wouldn't Views be a better solution for this?