Closed (works as designed)
Project:
Restrict IP
Version:
6.x-1.0
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
15 Mar 2011 at 14:21 UTC
Updated:
16 Mar 2011 at 14:51 UTC
I'm planning to do a bit of work on a site to implement some IP-based restrictions, and came across this module, which I'd rather contribute to, instead of writing my own. However, it appears you're not familiar with the Drupal coding standards as none of the code is written according to these.
I've done the following:
- Used two spaces instead of tabs for indent.
- Opening braces and brackets moved to the same line as the preceding statement.
Coding standards aside, it's very disappointing to see that you haven't written any comments in the module whatsoever. The code itself is sound, but no good programmer would leave code like this undocumented. I have added a basic level of documentation only, as part of this patch.
| Comment | File | Size | Author |
|---|---|---|---|
| restrict_ip_coding_standards.patch | 13.1 KB | chriscohen |
Comments
Comment #1
jaypanThank you for taking the time to do this, however I am well aware of the Drupal suggested coding standards, and have chosen not to follow them. They are not requirements. If you have any features you would like implemented, please feel free to request them and I will be happy to implement it, but on the modules I host I choose to stick to my own coding standards, as coding standards are purely aesthetic and have no bearing on how the code is executed.
Comment #2
jaypanComment #3
chriscohen commentedThis is a very disappointing attitude. Before going further, I want to point out that the Drupal community is one of the main reasons for Drupal's popularity and continued success. It's because so many people have worked (hard) together on Drupal's core and contributed modules that it is able to evolve as it has.
By choosing not to follow coding standards, you're making sure that contributors of patches, such as me, would either have to adopt your coding style, or, as is more likely, not contribute. You're also making it harder for people reviewing your code to determine if it is secure, since they have to learn to adapt to a new style of code. Not to mention you're missing out on the community as a whole.
Now I'd like to refer you to http://drupal.org/documentation/cvs/projects which states "Make sure your project is release-ready, secure, has a well-written project description, and follows Drupal's coding standards."
If you don't accept this patch, I am going to have to submit yet another module to Drupal, which is going to duplicate existing functionality. I'm sure nobody wants that, so I hope you'll reconsider.
Comment #4
jaypanOne of the other things that has made Drupal so strong is a choice of modules for various tasks. If you would like to create a new one, I only see that making the overall system stronger, not weakening it.
However, if you'd like to commit a patch for a new feature, you are more than welcome to do it whatever coding style you like, I don't mind that at all. I just convert it to my own style after applying the patch. I've done this with other patches in the past. I have no problems with other coding styles, and I use whatever style is required when I am working for someone. But on unpaid projects that I maintain alone, I choose to use my own coding style, as the work I do is an act of love, not of duty.