sub-theme logo.png not used
drpratten - January 14, 2007 - 21:02
| Project: | Drupal |
| Version: | 7.x-dev |
| Component: | color.module |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Jump to:
Description
While minnelli sub-theme has its own logo.png this is used only on the default color "Blue Lagoon". Once another predefined color set is chosen or custom color set defined, color.module reverts to garland's logo.png.
To reproduce this error, substitute another small .png with filename minnelli\logo.png . Make Minnelli the default theme. This new logo will appear. However once the color set is changed away from "Blue Lagoon" or a custom color set defined, color.module will revert to using Garland's logo.png instead.
This problem was discovered while trying to create a sub-theme to Garland as the preferred solution to http://drupal.org/node/109146
#1
Not true. You are simple not supposed to edit logo.png to change the logo.
Both Garland and Minnelli generate their own logo based on color/base.png. If they didn't you would still see a blue background behind the logo, as logo.png is not transparent.
To use a custom logo, upload it through the UI interface, or edit color/color.inc and color/base.png.
#2
OK - got it. I see now my area of misunderstanding.
Thanks for your feedback. Here is a feature request.
Any chance of providing a simple way for color.module to extract its logo out of a separate file?
It would be great to be able to create a default logo for a sub-theme without 'branching' the base.png file which is part of garland.
The logo.png is in a separate directory to most of the image files that color.module recreates
This suggests that the logo is in a separate category.
How about the following ...
'slices' => array(
'../images/body.png' => array('../color/base.png', 0, 37, 1, 280),
'../images/bg-bar.png' => array('../color/base.png', 202, 530, 76, 14),
'../images/bg-bar-white.png' => array('../color/base.png', 202, 506, 76, 14),
'../images/bg-tab.png' => array('../color/base.png', 107, 533, 41, 23),
'../images/bg-navigation.png' => array('../color/base.png', 0, 0, 7, 37),
'../images/bg-content-left.png' => array('../color/base.png', 40, 117, 50, 352),
'../images/bg-content-right.png' => array('../color/base.png', 510, 117, 50, 352),
'../images/bg-content.png' => array('../color/base.png', 299, 117, 7, 200),
'../images/bg-navigation-item.png' => array('../color/base.png', 32, 37, 17, 12),
'../images/bg-navigation-item-hover.png' => array('../color/base.png', 54, 37, 17, 12),
'../images/gradient-inner.png' => array('../color/base.png', 646, 307, 112, 42),
'logo.png' => array('color/other.png', 622, 51, 64, 73),
'../screenshot.png' => array('../color/base.png', 0, 37, 400, 240),
),
There may be better ways of achieving this ...
Many useful sub-themes could be created just by providing specific color options, specific css and drop in logo files (with transparency) - without the need to mess with base.png
#3
I do agree with such a suggestion:
using the Administer page isn't suitable, since a designer/admin may want to deploy his themes in a very simple way i.e. all the file inside the theme folder would be provided at once (package-wise) without the need to override the default logo by manually alter the theme configuration.
In other words: the "default" Logo should already be the "right" one.
Furthermore:
At different places in the documentation, the usage of an already existing theme as a template for own theming is firmly recommended.
Though, the exigence of redesigning the base.png in case of color scheming isn't well documented. A newby designer/admin (like I am) may not be aware of this.
#4
Feature requests go to D7.x-dev. Reassigning.