With system time set to 24hr there is no AM/PM in the quote string. The following works for Thunderbird on Ubuntu with 24hr time:

|| preg_match("/On.\d{1,2}\/\d{1,2}\/\d{1,2}.\d{1,2}:\d{1,2},.+?wrote:/s", #Thunderbird 24hr "On 21/5/10 13:45, Joe Smith wrote:"

CommentFileSizeAuthor
#3 1093440-quote-filter-tbird-24hr-D6.patch1.01 KBmholloway

Comments

kyle_mathews’s picture

kyle_mathews commented
Version: 6.x-1.0-beta6 » 6.x-1.x-dev

If you could create proper patch, it'll be much easier for me to apply that (and any future changes you make). See http://drupal.org/node/744486/git-instructions for instructions on how to do that.

Thanks!

mholloway’s picture

mholloway commented

Yes of course, will do. Apologies. I wasn't 100% sure how to do that with git so thanks for the pointer.

Mike

mholloway’s picture

mholloway commented
StatusFileSize
new 1093440-quote-filter-tbird-24hr-D6.patch1.01 KB

Patch created. Please let me know if anything not right.

Mike

kyle_mathews’s picture

kyle_mathews commented
Status: Needs review » Fixed

Awesome! Committed. Also what's cool is you're now credited with that patch. You're an official OG Mailinglist patch writer now :)
http://drupal.org/node/744486/committers and http://drupal.org/node/744486/commits

I <3 Git!

kyle_mathews’s picture

kyle_mathews commented

Oh, also it shows up on your user page - http://drupal.org/user/143453

mholloway’s picture

mholloway commented

Excellent! Drupal + Git is a phenomenal combo.

It's an honour to have my first committed patch on such a great module :)

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.