5.x release?

Hope to see this soon! It's pretty important for one of my clients who is moving to 5.x.

Hi, I'm being thrown into the access control world by a new client who needs user-based access control for Drupal 5.

The twist is that children nodes (of the node relativity module) have to inherit the parent node permissions, but that seems a fairly straightforward extension of nodeaccess once its updated to 5.

It's for a charitible cause but decent money nonetheless that I can pass along. However, I'm tackling this by tomorrow morning, so... I hope I can help, one way or another.

- ben :: http://AgaricDesign.com

i'm trying to port it from 4.7 to 5.1.
the differences of the access-system are not so big, but lots of changes in from-api are causing big trouble!
debtman7: do you have this task on your schedule? do you have time to help?

this worked for me with 5.1 (RENAME it to .zip)

most mods where UI updates (form api changed from 4 to 5)

Again, I can throw in a bounty for this to get done quickly.

Heimstein, are you doing your work in a publicly available CVS?

- ben :: http://AgaricDesign.com/contact

keep the bounty for the animals... download an test my update! ;-)

TIP:
using access-control does not hide inaccesible things in menus when unprivileged users or no user is logged in!

so, if one wants drupal to do good with access-per-node, one should also study:
http://drupal.org/node/16542
and apply
http://drupal.org/files/issues/menu_node_access_HEAD_1.patch

this bad habit was in 4.7 and survived also in 5.1... i cannot imagie, why nobody merge this into main-distribution. for me all kinds of access-systems where useless before!

of course, debtman7 was right and i was very stupid to think thats all. there are more changes http://drupal.org/node/64279#node_access

it seems, that most of it can be ignored, if one does not need more-than-one node_access system at the same time. in my patch, default permissions does not work. currently i think, that drupal core or node-module kills the just-written rows in the node_access table.

first, i will make the quickN'MOST(!)DIRTY implemet without concerning http://drupal.org/node/64279#node_access

! I DO NOT RECOMMEND THIS APPROACH !

but sorry, and with all due respect to the drupal-node-guys:
i need not many crap-like access-systems, but working one. an i really dislike super-indirect-access to everything.

you can wipe out drupal5's new interference to the node_access tabel by commenting out 2 lines in node.modul (approx line 2933):

function node_access_write_grants($node, $grants, $realm = NULL, $delete = TRUE) {
  if ($delete) {
    $query = 'DELETE FROM {node_access} WHERE nid = %d';
    if ($realm) {
      $query .= " AND realm in ('%s', 'all')";
    }
// HERE
//    db_query($query, $node->nid, $realm);
  }

  // Only perform work when node_access modules are active.
  if (count(module_implements('node_grants'))) {
    foreach ($grants as $grant) {
      if ($realm && $realm != $grant['realm']) {
        continue;
      }
      // Only write grants; denies are implicit.
      if ($grant['grant_view'] || $grant['grant_update'] || $grant['grant_delete']) {
// AND HERE
//        db_query("INSERT INTO {node_access} (nid, realm, gid, grant_view, grant_update, grant_delete) VALUES (%d, '%s', %d, %d, %d, %d)", $node->nid, $grant['realm'], $grant['gid'], $grant['grant_view'], $grant['grant_update'], $grant['grant_delete']);
      }
    }
  }
}

Bounty for animals? But I'm vegetarian! Heimstein, I just missed your patch when posting mine-- but I get a binary file when I download it, I'm used to being able to see patches...

Benjamin Melançon:
Since i'm not allowed to upload .zip (yes, thats true!) and i'm to stupid to create patches, i renamed a zip-file to xyz.zip.patch and uploaded it. simply rename ist back, unzip and checkit out.

RENAME Attachment: nodeaccess5.zip_.patch ===> nodeaccess5.zip ===> unpack ==> copy

;-)

debtman7: what do you think about a connection to "category-module" as an extension to nodeaccess? (my choice was category, not taxonomy)
i think about a simple access-inheritance along the category-hierachy... (like ntfs does on windows)
based your module (which works fine for me again since a few hours) it should not be to hard. cac_lite also has not survived the 4 => 5 port... i will try it, but again in the dirty way... so if there would a code-beautyfyer...
ps: playing around too much with my fingers, i injured my ear, but fortunately ears are not so mandatory for coding... ;-)

hello debtman7, after each execution of _nodeaccess_save_new() you should clear the menu-cache automatically. unless you do, you got now menu-updates, of course. this was irritating to me for a long time. for the sake of newbs.