This small patch removes the target attribute, replacing it by a CSS class that may used by some jQuery code to add the target attribute on clientside.
It also uses l() and adds a missing space.

CommentFileSizeAuthor
#4 gmap_target_blank_validation_1094468_1_4.patch659 bytesv1nk
#2 gmap_target_blank_validation_1094468_1_2.patch660 bytesv1nk
gmap.module.patch587 bytesanrikun

Comments

podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Version: 6.x-1.1 » 7.x-2.x-dev
Status: Needs review » Needs work

please, provide patch against latest dev

v1nk’s picture

v1nk commented
Assigned: Unassigned » v1nk
Issue summary: View changes
Status: Needs work » Needs review
Issue tags: +dcuacs2015
StatusFileSize
new gmap_target_blank_validation_1094468_1_2.patch660 bytes

Status: Needs review » Needs work

The last submitted patch, 2: gmap_target_blank_validation_1094468_1_2.patch, failed testing.

v1nk’s picture

v1nk commented
Status: Needs work » Needs review
StatusFileSize
new gmap_target_blank_validation_1094468_1_4.patch659 bytes
valentine94’s picture

valentine94
Location Kyiv, Ukraine
commented

Looks nice, +1 to RTBC

paravibe’s picture

paravibe commented
Assigned: v1nk » Unassigned
Status: Needs review » Reviewed & tested by the community

Looks good.

The last submitted patch, gmap.module.patch, failed testing.

v1nk’s picture

v1nk commented
podarok’s picture

podarok
🇺🇦 he/him/his
Primary language Ukrainian
Location Ukraine
commented
Status: Reviewed & tested by the community » Fixed
Issue tags: +CodeSprintUA

thanks, merged

  • podarok committed f3a738a on 7.x-2.x authored by v1nk 
    Issue #1094468 by v1nk, anrikun, paravibe, Valentine94: gmap_filter_tips...

Status: Fixed » Closed (fixed)

Automatically closed - issue fixed for 2 weeks with no activity.