Posted by scor on March 16, 2011 at 3:59pm
2 followers
Jump to:
| Project: | Comment notify |
| Version: | 7.x-1.x-dev |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | active |
Issue Summary
comment_notify_unsubscribe_by_email() and comment_notify_unsubscribe_by_hash() turn off the notify column and both leave a record in the comment_notify table, e.g.:
$update_query->fields(array('notify' => 0));
I might be missing something but why keep these stale records? If a user unsubscribes, the notify record could be remove so as to not collect clutter in this table.
Comments
#1
Good question. I think this is based on the original design of the module where it added a column to the comments table. So when we stopped doing that for some reason it seemed natural that it should be a 1:1 relationship to the comment table but there's really no need for that.
I've restated the title to match what I think we agree we should do.