Needs review
Project:
SOAP Server
Version:
6.x-3.0-alpha1
Component:
Code
Priority:
Normal
Category:
Task
Assigned:
Reporter:
Created:
16 Mar 2011 at 16:15 UTC
Updated:
25 Nov 2014 at 13:52 UTC
Jump to comment: Most recent
Lets reach a consensus as to what needs to be done for alpha, beta and stable release of this module.
I can see the following requirements:
1. Security audit
2. Review and fix simple test
3. Review and update documentation
If anybody wants to take these on that would be great, otherwise I will get round to it eventually.
Comments
Comment #1
mradcliffeI will be working with this module in Drupal 7. I have done some basic testing (not automated) on functionality and found it working with my modifications. I'll make a task for this when I can focus on it more. That will probably be within 2 weeks.
Comment #2
fuzzy76 commentedSubscribing. Can't help notice the lack of commits since 1. february.
Comment #3
marcus_clements commentedI am using this module on production sites but in combination with another custom module that rewrites the WSDL using a hook. I would really like to get some test feedback from other users so that we can move towards a release.
@fuzzy76 - do you have a real world test for the module where it connects to an external soap server, ideally not a PHP implementation for the best confirmation of cross compatibility.
Comment #4
fuzzy76 commentedUnfortunately, my use case is Drupal being called as a SOAP server from other internal systems. They are based on Microsoft-technology, though, so they would probably make for an excellent test. However, I am not in charge of the other system, so I won't be able to test it right away. I use http://ditchnet.org/soapclient/ for internal testing.
Comment #5
marcus_clements commentedSorry my post didn't really make sense did it. I meant to say that a good test would be to connect to Soap Server with an external client that is not written in PHP. If you do get the chance to post any results here that would be great.
Comment #6
fuzzy76 commentedThat makes much more sense. :) Is the 6.x-3.x-dev snapshot from 2011-feb-25 up to date for testing then?
Comment #7
marcus_clements commentedI have altered the WSDL to pass WSI conformance in SOAP UI and made an alpha release.
Feedback from anyone connecting to SOAP Server with any kind of client is very welcome, even if it's just a simple node retrieve.
Comment #8
mradcliffeThese changes apply fairly cleanly to my 7.x-3.x branch, and the service still works. +1 tested/reviewed.
In terms of real world implementation, I have also had SOAP UI tests and soon WebSphere.
Comment #9
marcus_clements commentedGreat. Do post a patch against the 7.x-3.x head if you get the chance. I'll review and commit as soon as I get time.
Comment #10
mradcliffeI uploaded all the patches generated via
git format-patch origin/7.x-3.x..7.x-3.xwhere "7.x-3.x" is my local git branch. This includes recent commits made to origin/6.x-3.x.Sometimes git is your friend :)
Comment #11
fuzzy76 commentedAtleast http://ditchnet.org/soapclient/ seemed to consume the service nicely. +1 for tested (will do more extensive testing the next days as I finish my production code).
Comment #12
mradcliffeI can confirm an external service is using an overridden wsdl Soap Server service.
Comment #13
marcus_clements commentedWe now have alpha releases for 6.x-3.x and 7.x-3.x
I still think it would be really helpful if someone could give the module a security audit.
Comment #14
fuzzy76 commentedI can also confirm the service working with PHP's own SOAP extension.
Comment #15
fuzzy76 commentedOur service is still running, now consumed regulary by a .Net client.