There are numerous PHP warning messages that are displayed on various pages once the Kaltura modules are enabled. Many are due to variables, array keys, and object properties that are not defined in all cases. Resolving these issues is part of coding best practices. See: https://drupal.org/node/34341

CommentFileSizeAuthor
#3 kaltura-1094876-3-fix_php_warnings.diff17.91 KBarithmetric
#1 kaltura-1094876-1-fix_php_warnings.diff18.39 KBarithmetric

Comments

arithmetric’s picture

arithmetric commented
StatusFileSize
new kaltura-1094876-1-fix_php_warnings.diff18.39 KB

Attached is a patch that resolves the warnings that were most visible to me and had a clear solution. There are most instances to fix, but it would be great to get these first fixes committed.

arithmetric’s picture

arithmetric commented
Status: Active » Needs review

[bumping status]

arithmetric’s picture

arithmetric commented
StatusFileSize
new kaltura-1094876-3-fix_php_warnings.diff17.91 KB

Attached is an updated patch against the 6.x-2.x branch.

xurizaemon’s picture

xurizaemon
he/him
Location Ōtepoti, Aotearoa 🏝
commented

@arithmetic, I'm afraid some of the patch above will be removed by fixes in #1026426: Installation issues: FAPI rewrite of installer. The rest is very welcome.

I hope to have that ticket sorted shortly and then will be able to review and re-roll your patch above with the remaining items.

Thanks! Will leave as review for now.