sWmode Opaque / Caching / Code-Cleanup
AdrianB - January 15, 2007 - 14:13
| Project: | sIFR |
| Version: | HEAD |
| Component: | Code |
| Category: | task |
| Priority: | normal |
| Assigned: | sun |
| Status: | closed |
Description
I needed to set sWmode to "opaque" but I coudn't find the setting for this. There is a "transparent" option for sWmode already, so it should be a minor change. (I did it myself as an ugly hack and it worked.)
Why opaque mode? It's sometime needed to place menus (like nice menus) above sIFR text (and other flash movies), especially in IE/win.
This is my first issue here, so be gentle if I done something wrong.
#1
Attached patch adds support for opaque. Note: It's for HEAD/5.x.
#2
Whilst working on this issue I've recognized that the output of sIFR isn't cached at all, but could be, since it's usually setup just once for a site. So the attached patch additionally introduces a (variable) cache for sIFR.
Furthermore, the generation of a sIFR rule was a bit hacky. So this patch also optimizes that code for better readability.
@jjeff: Are the changes ok with you?
I know, mixing several issues in one patch isn't welcome. So please don't blame me for that. If the proposed changes are ok with you, I'll commit that patch to HEAD and 5.x.
#3
Committed to HEAD and 5.x.
#4