Update webserver_auth to 5.x

Here's another, more comprehensive patch.

Works with Apache/NTLM and pgsql.

(Should work with MySQL as well...)

I am assuming that use of webserver_auth LDAP features under Drupal 5.x is dependent on recently-orphaned LDAP integration module getting sorted out and updated to version 5. I see some activity on that module, but hard to tell if it is coming to a 5.x conclusion.

geste wrote:

I am assuming that use of webserver_auth LDAP features under Drupal 5.x is dependent on recently-orphaned LDAP integration module...

No, it doesn't. However, it does rely on a working Samba installation, which is not for the faint of heart or the lacking in cluefulness...

My apologies. I was getting my modules mixed up. I have a working Samba+LDAP installation, but am using PubCookie for auth. Looking back at my 4.7, installation I see that the function I was concerned with (mapping LDAP info into Drupal profiles) is actually in ldap integration. So my question was misplaced.

It may simply be my noob cluelessness, but I had no luck with either of these patches (applied against 4.7-dev download). This was on a new Drupal 5.1 install with LDAP integration added. Maybe it ios benign, but Bob's longer patch complains of a couple chunks not processed and produced a .rej file (which I could certainly forward). When I put that patched module in place, it errs out (blank page) when I log out and try to let WebAuth take over.

Anyhow, I am curious to know if you might be on the verge of committing this as 5.x. I am thinking if I can work with a new revision, I am less likely to shoot myself in the foot, patch-wise.

I have this running with 4.7 and it is grand. Thanks. Jim

Skor,

Thanks. Just to get the basics going, I tried the "simple" update again (edit 4.7 "module_exist/s" and add info). I had it choke (go blank) once when I reloaded admin page, but it is working now.

A couple of points/questions:

Under 4.7 I had one small webserver_auth admin/settings page that let me set the email domain. If that exists under 5.x I am not seeing it. So I am trying to set in webserver_auth.module webserver_auth_settings with '#default_value' => "example.com", but this is not working yet.

New users are added to Drupal, but it does not add email yet and users initially get the following set of warnings (just on first access):

warning: array_keys() [function.array-keys]: The first argument should be an array in /var/www/html/modules/user/user.module on line 361.
warning: implode() [function.implode]: Bad arguments. in /var/www/html/modules/user/user.module on line 361. user
warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT DISTINCT(p.perm) FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN () in /var/www/html/includes/database.mysql.inc on line 172.

This set of warnings only appeared after I added webserver_auth module.

This is on an install with ldap_integration installed (though ldap_data is not released for 5.x yet) Not sure what is interacting with user.module here -- webserver_auth or ldap_integratyion....

Thanks,

Jim

FWIW, I ran the patch on the HEAD version and got the same error (below) as geste did, also upon first login. I am not using ldap_integration.

* warning: array_keys() [function.array-keys]: The first argument should be an array in C:\Inetpub\wwwroot\MCB\drupal5\modules\user\user.module on line 361.
* warning: implode() [function.implode]: Bad arguments. in C:\Inetpub\wwwroot\MCB\drupal5\modules\user\user.module on line 361.
* user warning: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near ')' at line 1 query: SELECT DISTINCT(p.perm) FROM role r INNER JOIN permission p ON p.rid = r.rid WHERE r.rid IN () in C:\Inetpub\wwwroot\MCB\drupal5\includes\database.mysql.inc on line 172.

I used the above copy of the patch. No change. Still got the same error messages.

FYI, I never did get the webserver_auth configuration to show up under administration, so there was nowhere to configure mail domain. However, I went back and looked at my 4.7 installation and simply added a record to"variables" table:

webserver_auth_domain s:11:"example.com";

s:11 would be replaced by s:X where X is length of email domain.

So now webserver_auth adds email when it adds new user.

Jim

I think I may have found the conflict with this patch: the Profiles Module.

I have disabled the profile module, and I still got the errors mentioned above!!

any more ideas?
this is a great module for my intranet !!

I think I know what the problem is now, I don't know how to fix it though

The problem is access roles, the user that is created get access role 0 in authmap which generates this error because access role or RID cannot be 0, it have to be either 1 or 2 (1 is anonymous, and 2 is authenticated users, and so on)
However, this is what the user.module complains about, it seem to create the user perfectly but it doesn't create the rid correctly (probably because we don't use hook_user and user_save correctly)

I am to bad at programming to know how to convert the user_default array and the $user = user_save ( kasdlaksldk) array to hook_user() and user_save()
but I believe that if we do, we'll solve these problems.

I tried to do a dbquery that updates the authmap table and inserts rid = 2 where rid = 0, but it doesn't work until the user does a refresh of the page after doing his/hers first login,so it has to be solved inside the user_save() funktion if we are going to solve this.

this is also similar to this: http://drupal.org/node/56663 node.

I got it working!! Without the errors!!

Remove the line: $user = user_external_load($account->name);

and it shoudl work as expected without the sql errors

ok sorry guys, doesn't quite work as expected..

when I remove that line, all work great, until I try to logout, then it tries to recreate the account (which failes with a lot of sql errors)..

so I am trying to come up with a solution, but my ideas are running out, i believe the trouble is that $user is an array but when we load with user_external_load() it isn't an array anymore, but I can't figure out what to do...

ok, now it actually works!
no errors, the database seems fine, and this funktion is from the 4.7 version (not head) and also not the one found in this thread, but it should work with those too..
I am doing a database request to see if the user uid exist, and based on that it uses user_external_load, OR NOT!

function webserver_auth_init() {
  global $user, $account;

  if ($user->uid) {
    //do nothing because user is already logged into Drupal
  }
  else {
    if ($name = $_SERVER["REMOTE_USER"]) {
      // user is logged into webserver.
      $account->name = $name;
      //modules get to change the user bits before saving. use a global $account to do so.
      // only loaded modules will see this hook
      module_invoke_all("webserver_auth");
      // if we are in bootstrap, load user.module ourselves
      if (!module_exists('user')) {
       drupal_load('module', 'user');
      }

      // try to log into Drupal. if unsuccessful, register the user
     //if ($user = user_external_load($account->name);
    $query = db_query("select * from users where name = '%s'", $account->name);
    $user_exist = db_result($query);
    print $user_exist;
if ($user_exist == 0)
{
	  if (!$user->uid) {
        if (variable_get("user_register", 1) == 1) {
          $user_default = array("name" => $account->name, "pass" => "cyan", "init" => db_escape_string($name), "authname_webserver_auth" => $account->name, "status" => 1, "roles" => array(DRUPAL_AUTHENTICATED_RID));
          // TODO - the hook_user('register') will fire but only for loaded modules. cold be a problem for sites using page cache and that hook+operation
          $user = user_save("", array_merge($user_default, (array)$account));
          watchdog("user", "new user: $user->name (webserver_auth)", l(t("edit user"), "admin/user/edit/$user->uid"));
        }
else {
}
      }
      else {
       }
       
     }
     else {
    $user = user_external_load($account->name); 
	  }
      
    }
  }
}

I've been reading these emails and was not able to get webserver_auth to work.

I'm using mod_auth_mysql to authenticate to the Drupal database and needed an auto login to Drupal using the PHP basic authentication variables. Attached is the module I've called "phpauth".

You might want to look at it, I started with webserver_auth and looked at ldapauth.
It's very simple when you use the $user->name field instead of looking up the $account information and use user_authenticate.

I'm new to Drupal and don't begin to fully understand the module system.

I'm not sure why webserver_auth isn't using a password field and I have no idea what the function webserver_auth_webserver_auth is doing.

I added a phpauth_info function as it says it's required.

Although I couldn't get webserver_auth to work, it got me started in the right direction.

The attachment is a zip file that I put a .patch extension on to get it to send.

Thanks...

Hello, I'm new on Drupal. Will there be a release for drupal 5.1?

Correct typo in Title

I committed the original patches, and added a menu callback so you could use the one setting that this module offers. If there are more bugs, please file them in new issues. So sorry for the massive delay.