Emailed comments and replies are not properly threaded. All are displayed at same level.

I believe this is due to the comment parent id not being set when saving the comment.

Patch to follow shortly.

CommentFileSizeAuthor
#7 1095824-add-option-to-thread-comments-D6.patch2.19 KBmholloway
#1 1095824-comments-not-threaded-D6.patch1.2 KBmholloway

Comments

mholloway’s picture

mholloway commented
Status: Active » Needs review
StatusFileSize
new 1095824-comments-not-threaded-D6.patch1.2 KB

This patch assigns the comment's parent pid to the cid of the in-reply-to comment.

mholloway’s picture

mholloway commented

Second thoughts. Is this a good idea?

Does it make sense to display mailing list type conversations in a threaded layout? Likely to indent ridiculously very quickly and I'm guessing most respondents will reply to latest email to arrive so threading not an issue.

On the other hand comment settings on the node type can be used to select flat or threaded.

Thoughts anyone?

Shai’s picture

Shai commented

@mholloway

You wrote,

On the other hand comment settings on the node type can be used to select flat or threaded.

'

You've answered your question. All things being equal, due to the ability to present comments in a flat format, I think your patch is a good idea.

I'm not in a position to review the patch (or even test it at this point since I haven't successfully installed the mail transport stuff on my server). If maintaining threading is difficult to maintain or has unintended consequences, then it's probably not worth it. But otherwise, I think it's important to provide the possibility of maintaining threading.

It should be noted that even via the normal comments UI on the web users can mess up the threading by clicking reply in the wrong place.

Shai

tobias’s picture

tobias commented

I am into this idea - I think it's a great idea to have discussions threaded, even if it is inconsistent when people use different behavior to contribute to discussions.

Cheers,

Tobias

mholloway’s picture

mholloway commented

Thanks for the feedback. It's a one line patch and although we all know what damage they can do(!) it really just causes a value to be set in the thread column of Drupal's comments table, so should be harmless and, if not, is easily removed.

Would be interesting to hear Kyle's view.

kyle_mathews’s picture

kyle_mathews commented
Version: 6.x-1.0-beta6 » 6.x-1.x-dev

In general I dislike comment threading for the reasons you've mentioned which is why I've never enabled it. But it is easy to add support for it and some people will want it. So I'll commit your patch but please make it toggable in the ogm admin interface. E.g. add a checkbox there that people can turn it off or on.

mholloway’s picture

mholloway commented
StatusFileSize
new 1095824-add-option-to-thread-comments-D6.patch2.19 KB

Good idea. Checkbox added.

Apologies for raising this as a bug when really it's a feature request.

kyle_mathews’s picture

kyle_mathews commented
Status: Needs review » Fixed

Looks great! Thanks. Fix committed:
http://drupalcode.org/project/og_mailinglist.git/commitdiff/d23f063?hp=d...

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.