Update fb_example module for drupal 7

cool, thanks for that!

So, you're recommending the second patch, right? I don't know what "no-prefix" means.

That's funny, I just did a port of the same module cause I needed it for D7. Should have checked the issue queue before I started.

Overall yours looks better Steve but I included the optional file includes (http://drupal.org/node/542202) in the fb_example.info file

files[] = fb_example.install
files[] = fb_example.module

and the correct drupalforfacebook.org spelling in the description column
description = These hooks will make your site behave more like drupalforfacebook.org. Use this code as an example for your own customizations.

Received the error
DatabaseSchemaObjectExistsException: Table xxxxx already exists. in DatabaseSchema->createTable() (line 623 of http://xxx\xxx\xxx\xxx\includes\database\schema.inc).
On trying to re-enable the custom examples module regarding fb friends table.

Thanks to post #995094: DatabaseSchemaObjectExistsException I read that "probably means that your module is incorrectly calling drupal_install_schema() in its hook_install(). This is not necessary anymore as Drupal is calling this for you automatically."

After deleting lines 12 and 13 of the fb_friend.install that refer to the line above everything seems ok at first glance.

First try to patch with NetBeans, on the contrib folder (I guess... cannot see further informations about wich other folder could be affected by this patch)

Patching is incomplete after :

# This patch file was generated by NetBeans IDE
# It uses platform neutral UTF-8 encoding and \n newlines.
--- C:\dev\sites\all\modules\fb\contrib\fb_example.install.original~
+++ C:\dev\sites\all\modules\fb\contrib\fb_example.install
@@ -6,14 +6,29 @@
  */
 
 
-// Set weight so that fb_example comes after fb_user.
+/**
+ * Implements hook_install().
+ *
+ * Set weight so that fb_example comes after fb_user.
+ */
 function fb_example_install() {
   // So we fall after og_vocab and og
-  db_query("UPDATE {system} SET weight = 3 WHERE name='fb_example'");
+  db_update('system')
+  ->fields(array(
+    'weight' => 3,
+  ))
+  ->condition('name', 'fb_example')
+  ->execute();
 }
 
+/**
+ * Implements hook_update_N().
+ */
 function fb_example_update_1() {
-  $ret = array();
-  $ret[] = update_sql("UPDATE {system} SET weight = 3 WHERE name='fb_example'");
-  return $ret;
+  db_update('system')
+  ->fields(array(
+    'weight' => 3,
+  ))
+  ->condition('name', 'fb_example')
+  ->execute();
 }

On fb_example.install

How to fix this ?
Thanks a lot for your work.

I had posted too quickly after trying this. It look like more is needed because while I was able to install it, I was unable to see any of the blocks added to my blocks page. I'm afraid it will take some more digging.

Wish I could help you with the patch Undead Woody but I will have to learn a bit more on modules and patching!

Could someone eventually send the successfully patched fb_example files ?

Got the patch from Steve implemented. Deleted the offending code in the FB_Friends module so that it "seems" to install without throwing the error.

I now see the like button added to nodes *cheers* however no example blocks or additional features showing. No biggie since I'm using social plugins I can implement myself but wanted to report.

Okay, so the D7 example module doesn't work at all in the dev version right now? Would be good to know.

What is the status of this issue? There have been several updates but still this functionality seems to be missing. I've had trouble with a netbeans patch as well.

Has anyone got this working? Badly need this feature.

Cheers.

The fb_example module for 7.x-3.x-dev should not have drupal 6 hooks in it! This really needs to be fixed, bumping up to major priority. The patches above did not apply cleanly on 7.x-3.x-dev for me.

Apparently there was a bounty for this: http://drupal.org/node/1348040 but nothing was contributed from it?

I guess I lost track of this patch when it was new. no longer applies cleanly.

Remember the fb_example module is intended to be snippets that you might use in your own custom hooks. Not actually intended to be enabled on live sites. There's a lot of customization you can control in code, and this module is intended to show how that can be done. It's not meant to do what's appropriate for your particular site whatever that may be.

Subscribing...

Remember the fb_example module is intended to be snippets that you might use in your own custom hooks. Not actually intended to be enabled on live sites.

If that is the case, Can that be more clear on the project page?

Either way, I don't see any reason for the D7 branch to have D6 hooks.

@warmth: http://drupal.org/node/1306444 :)

@chrisjlee: can you believe I always complain about what I just did? LOL I'm sorry, I think I was in a hurry and didn't think before posting and closing the tab. My bad.

The patches did not apply for me. Here is my attempt at a re-roll.

A belated commit. I can't say I've tested everything in fb_example. If any problems, please submit new issue.