It isn't making complete sense to me to have the 'add another location' option on the node view page... shouldn't that be on the node edit page? I can understand why you may want to make adding of locations to nodes more accessible to people viewing the nodes, but it's still edit functionality.

Maybe if you're set on keeping it on the view page, add an administration option to let people choose whether it should be on the view or edit page.

I can see that adding the option to the edit page would (in its current form) break any other edits that had been made to the form, so perhaps the ability to add another location fieldset (when the amount of fieldsets shown already is less than the max amount) on-the-fly instead of refreshing the page?

Comments

csc4’s picture

+! to this - it's causing my users a lot of confusion!

geodaniel’s picture

Assigned: Unassigned » geodaniel
Status: Active » Needs review
StatusFileSize
new1.73 KB

a +!, you must be keen on the feature :)

I've attached a patch to give the admin the option to add this "Add another location" functionality on a per content type basis.

csc4’s picture

Too excited to type apparently!!

Thanks a lot for the patch too! amazingly speedy!

Tobias Maier’s picture

looks valuable, too

Tobias Maier’s picture

Status: Needs review » Reviewed & tested by the community

status...

Tobias Maier’s picture

StatusFileSize
new1.86 KB

updated this patch

geodaniel’s picture

Modified version (form element name didn't need $type appending to it) committed to HEAD and DRUPAL-5 branch - will backport to 4.7 too.

geodaniel’s picture

Status: Reviewed & tested by the community » Patch (to be ported)
geodaniel’s picture

Status: Patch (to be ported) » Fixed

committed to DRUPAL-4-7 branch too - thanks for the updated patch Tobias!

Anonymous’s picture

Status: Fixed » Closed (fixed)
bomarmonk’s picture

Status: Closed (fixed) » Postponed (maintainer needs more info)

Am I missing something? When I disable the "add another location" for the node view, there isn't a way to add another location in the edit form. Shouldn't there be a way to add a location from the edit form?

michelle’s picture

Version: 6.x-3.x-dev » 5.x-2.7
Status: Postponed (maintainer needs more info) » Active

Bumping this. There really needs to be a way to add another location from the edit page. My pages are themed so I didn't even know there was an option on the view tab until I read this issue because it doesn't show up on mine. Even if it did, it still needs to be on the edit tab.

Michelle

bomarmonk’s picture

And the real fun begins when you have locative information attached to a CCK content type that is themed with a contemplate. Currently, contemplate bypasses any modules linking to the bottom of the node body, so you either have to add the module's information with code in the template, or you are pretty much out of luck with this combination of modules (if you have more than one location for a node). Does anyone have a snippet of PHP that will add the "add another location" link to the bottom of a node? That would help in the meantime.

bomarmonk’s picture

Yes, I double checked and when the "add another location from view" is unchecked, the add another location does not show up in the edit form. Shouldn't it do this? I am using location with a CCK content type and Drupal 5.2. Is there a way to get the add link to show on the edit form?

bdragon’s picture

Status: Active » Closed (fixed)

Closing, I really think it's just a misconfiguration issue.

michelle’s picture

Status: Closed (fixed) » Active

Before you close this... Could you tell us how to configure it? I went all over the options and couldn't figure out any way to make location give you an option to add another location when you are adding/editing a node. It's been a while since I looked at it but, back then, I came to the conclusion that the functionality wasn't there and gave up. So, if it is, I'd love to hear how you do it. :)

Michelle

bdragon’s picture

Set "number of location forms" to > 1, I think.

michelle’s picture

Status: Active » Closed (fixed)

Ok, we just chatted on IRC and it looks like it's a bit better than I remembered. I thought if you wanted 30 locations allowed you had to put all 30 on from the get go. Turns out that there's another option to set how many show up to start with, that I really dont' remember being there before but I could be wrong. So that's still not ideal, but better. Putting this back to closed like Bdragon had it and this can be addressed in an over all FR to improve how locations are added.

Michelle

rickh’s picture

Sorry for commenting on a closed issue but, is there any way that this may be ported to the latest 6.x-3.1 version? I've had a look at [master]Improve UI for entering and geocoding of locations, but it seems it has hit a dead-end of sorts.