Needs review
Project:
Tiny Tiny MCE
Version:
6.x-1.x-dev
Component:
Code
Priority:
Normal
Category:
Bug report
Assigned:
Unassigned
Reporter:
Created:
17 Mar 2011 at 22:40 UTC
Updated:
27 Mar 2012 at 16:37 UTC
The link that toggles a textarea from plain to rich text uses an anchor tag with javascript in the href property. In some cases this could cause the browser to execute the javascript twice or more and is generally considered bad form. Instead javascript should be executed in the onclick property and href should point to a valid url (or "javascript:void(0);").
This patch changes the toggle link from
<a href="javascript:toggletinyMCE('edit-body')">rich text editor</a>
to
<a href="javascript:void(0);" onclick="javascript:toggletinyMCE('edit-body')">rich text editor</a>
| Comment | File | Size | Author |
|---|---|---|---|
| javascript-toggle.patch | 1 KB | draenen |
Comments
Comment #1
draenen commented