Download & Extend

Rich text link uses href="javascipt:..." and could be called multiple times

Project:Tiny Tiny MCE
Version:6.x-1.x-dev
Component:Code
Category:bug report
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

The link that toggles a textarea from plain to rich text uses an anchor tag with javascript in the href property. In some cases this could cause the browser to execute the javascript twice or more and is generally considered bad form. Instead javascript should be executed in the onclick property and href should point to a valid url (or "javascript:void(0);").

This patch changes the toggle link from

<a href="javascript:toggletinyMCE('edit-body')">rich text editor</a>

to
<a href="javascript:void(0);" onclick="javascript:toggletinyMCE('edit-body')">rich text editor</a>
AttachmentSize
javascript-toggle.patch1 KB

Comments

#1

Status:active» needs review
nobody click here