If you subscribe to a thread, each comment produces a message containing only the title of the node at the top of the discussion, and if you enable the teaser, you just keep getting that node's teaser.

The issue is present for the other subscription types.

This patch delivers the title of the node plus the title of the comment, and if the teaser is enabled, it also delivers the comment text.

CommentFileSizeAuthor
subscriptions.module_5.patch4.19 KBsalvis

Comments

arthurf’s picture

arthurf commented

Ok, I've applied your patch. Can you test out the CVS version and let me know how it's working for you? If things look good, I'll apply the same fixes to the 5.0 module and release a new version of each.

salvis’s picture

salvis
he/his
commented

Yes, this looks good, thank you.

However, you may want to consider enabling the subscriptions_teaser checkbox to allow the administrator to make the teasers available. Right now it's commented out in lines 82-87 as discussed in /node/77036.

The "not ready for prime time" comment on line 87 presumably refers to the fact, that the teasers (and after my patch the comments, too) are delivered unfiltered, i.e. if they contain HTML, they're delivered with the HTML, but as text, so the recipient sees the HTML codes.

Of course it would be nice to filter the text to replace any HTML with suitable text-only formatting, but in the meantime I'd rather have teasers with HTML than no teasers at all...

ricmadeira’s picture

ricmadeira commented

You might want to look into and/or cannibalize the Organic Groups module. It HTML-filters the node/comment text it sends in e-mails to subscribers, and even provides a list of the links that were filtered out at the bottom of the e-mail. Works pretty good too!

arthurf’s picture

arthurf commented
Status: Needs review » Fixed

I've done some work to allow teasers to be sent and am filtering on them. Look for the theme body function which is where you can set this.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)