Unpublished nodes are visible in the feed — fixed.

Comments to unpublished nodes show up in email — fixed.

Unpublished comments show up in email — this needs work. The status field in the comments table has negative logic compared to the nodes table, i.e. 1 means unpublished, 0 means published. The place to fix this is the subscriptions_comment() hook function, but I'm somewhat confused — isn't the status condition near the beginning of the function exactly reversed?

CommentFileSizeAuthor
subscriptions.module_6.patch1.21 KBsalvis

Comments

arthurf’s picture

arthurf commented
Status: Needs work » Fixed

This fix is in cvs 4.7 and 5.0. Thanks for the patch

salvis’s picture

salvis
he/his
commented
Status: Fixed » Active

Thank you for checking it in, but as mentioned in the original post, the third issue is still open.

If comments are set to go to the moderation queue and not to appear on the site until they're released, Subscriptions sends them out immediately anyway.

arthurf’s picture

arthurf commented

Right. The comment handling needs some work, I will put this on the list of things to address.

mindless’s picture

mindless commented

i think this may be fixed for drupal 5.x.. do you need it for 4.7.x?

salvis’s picture

salvis
he/his
commented

No, not anymore -- I'm moving to 5.x and looking forward to check it out there...

Thanks!

mindless’s picture

mindless commented
Version: 4.7.x-1.x-dev » 5.x-1.x-dev
Assigned: Unassigned » mindless
Status: Active » Fixed

Great.. moving to 5.x and marking fixed. I did flip that status check.. please test it out and reopen this if needed.

Anonymous’s picture

(not verified) commented
Status: Fixed » Closed (fixed)