Early Bird Registration for DrupalCon Portland 2024 is open! Register by 23:59 PST on 31 March 2024, to get $100 off your ticket.
Unpublished nodes are visible in the feed — fixed.
Comments to unpublished nodes show up in email — fixed.
Unpublished comments show up in email — this needs work. The status field in the comments table has negative logic compared to the nodes table, i.e. 1 means unpublished, 0 means published. The place to fix this is the subscriptions_comment() hook function, but I'm somewhat confused — isn't the status
condition near the beginning of the function exactly reversed?
Comment | File | Size | Author |
---|---|---|---|
subscriptions.module_6.patch | 1.21 KB | salvis | |
Comments
Comment #1
arthurf CreditAttribution: arthurf commentedThis fix is in cvs 4.7 and 5.0. Thanks for the patch
Comment #2
salvisThank you for checking it in, but as mentioned in the original post, the third issue is still open.
If comments are set to go to the moderation queue and not to appear on the site until they're released, Subscriptions sends them out immediately anyway.
Comment #3
arthurf CreditAttribution: arthurf commentedRight. The comment handling needs some work, I will put this on the list of things to address.
Comment #4
mindless CreditAttribution: mindless commentedi think this may be fixed for drupal 5.x.. do you need it for 4.7.x?
Comment #5
salvisNo, not anymore -- I'm moving to 5.x and looking forward to check it out there...
Thanks!
Comment #6
mindless CreditAttribution: mindless commentedGreat.. moving to 5.x and marking fixed. I did flip that status check.. please test it out and reopen this if needed.
Comment #7
(not verified) CreditAttribution: commented