line 244 of securepages.module reads
return $TRUE;

Should it not return TRUE? Currently gives a PHP_NOTICE undefined variable $TRUE.

Also, not that its a problem, I'm just curious if there is any reason why line 228 in securepages_test() reads
$url = 'https://' . preg_replace(';^http[s]?://;s', '', url('admin/structure/securepages/test', array('absolute' => TRUE)));

and not
$url = preg_replace(';^http://;s', 'https://', url('admin/structure/securepages/test',array('absolute' => TRUE)));

Thanks,
Jonathan

CommentFileSizeAuthor
#1 crazy-true-is-a-variable-fix.patch405 byteschriscohen

Comments

chriscohen’s picture

StatusFileSize
new405 bytes

Please accept this patch to fix this issue. It's literally removing a single character, however. If the patch is not in the correct format, please let me know. I'm a bit alarmed that this issue has been around since March and there is no progress on it!

acbramley’s picture

Priority: Normal » Major
Status: Active » Reviewed & tested by the community

Can't believe this patch hasn't been accepted yet. Patch works fine, format is fine just get this into --dev!

grendzy’s picture

Status: Reviewed & tested by the community » Fixed

Fixed in 6a50441

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.