Admin forms in D7

Here's a first pass. The admin forms aren't fully working after this (not by any means) but they do whitescreen less often than they did before :)

I tried to focus mostly on the code in taxonomy_access_admin.inc (even though many API functions called from there are still broken). So it might be at a pretty good committable state.

Great, glad you were able to finish those up. I guess I didn't fully appreciate that if I signed up to "make the admin forms work in D7", doing that completely would basically be the equivalent of porting the entire module to D7 :)

Skimming through the committed patch, in _taxonomy_access_get_nodes_for_vocabulary():

-      // Exclude nodes with those terms from the results.
-      $query .=
-        " AND n.tid NOT IN (" . db_placeholders($tids, 'int') . ")";
....
+    // Exclude nodes with controlled terms from the results.
+    $query->condition('ti.tid', $tids, 'IN');

Is this change actually right? Looks like it switched from NOT IN to IN...

+    db_select('taxonomy_index', 'ti')
+    ->condition('td.vid', $vid)
+    ->fields('ti', array('nid'))
+    ;
+  $query->join('taxonomy_term_data', 'td');

This doesn't specify what columns to join on - I assume it needs to?