Use ShowFileRequestHandler, gettableFiles is deprecated

Well, I actually liked better the explicit listing of allowed files, since there could be various unexpected conf files, backups, etc that should not be exposed, which is why I stayed with the (deprecated) handler.

So, this doesn't seem to work to block a request to

http://localhost:8983/solr/admin/file/?file=xslt/luke.xsl

However, the xsl files are not listed in the admin interface.

The xsl files are not sensitive, I was mostly trying to avoid confusion in the UI by listing stuff a typical admin would not need to see.

So, if the files are not listed, maybe it doesn't matter.

I guess this update does require a notice so that the drupal administrator knows that solrconfig.xml has changed? Can we somehow see if the version is different and notify them?

Alright, didn't know the history or impact of these changes.
Marking as needs review

I was testing this patch and found out that apachesolr_config_files_overview doesn't work with solr 3.4
Have to test if it is the same behavior with solr 1.4 but I expect not.

In solr 3.4 the files table or response is being answered as an json_encoded string.

So indeed

Solr 1.4 :
<?xml version="1.0" encoding="UTF-8"?> 01913102010-06-17T17:07:48Z31142010-06-17T17:07:48Z1872011-11-14T11:29:27Z267552011-11-14T11:29:27Z306852011-11-14T11:29:27Z12292010-06-17T17:07:48Z11632010-06-17T17:07:48Z

Solr 3.4:
{"responseHeader":{"status":0,"QTime":25},"files":{"elevate.xml":{"size":1274,"modified":"2011-09-07T17:11:33Z"},"mapping-ISOLatin1Accent.txt":{"size":2868,"modified":"2011-09-07T17:11:33Z"},"protwords.txt":{"size":187,"modified":"2011-10-01T03:19:17Z"},"schema.xml":{"size":28104,"modified":"2011-10-01T03:19:17Z"},"solrconfig.xml":{"size":30703,"modified":"2011-10-27T14:04:22Z"},"stopwords.txt":{"size":781,"modified":"2011-09-07T17:11:33Z"},"synonyms.txt":{"size":1133,"modified":"2011-09-07T17:11:33Z"}}}

And in a followup

To know if we are running solr 1.4 or 3.4 we need to include the following handler

Then we can retrieve the following info :

<lst name="lucene">
<str name="solr-spec-version">3.4.0.2011.09.09.09.06.17</str>
<str name="solr-impl-version">3.4.0 1167142 - mike - 2011-09-09 09:06:17</str>
<str name="lucene-spec-version">3.4.0</str>
<str name="lucene-impl-version">3.4.0 1167142 - mike - 2011-09-09 09:02:09</str>
</lst>

Will make a proof of concept code

This patch supports multiple versions of solr (1.4 and 3.4)

• Adds admin/system handler
• Checks if the lucene version is higher or lower then 3
• Includes the patch from earlier in this issue
• Depending on the version of Solr it will parse the resultset differently
• Removes some spacing problems in solrconfig.xml

Clean patch that does not take those whitespaces into account

One more fix

And using a table, much prettier and less clunky :)

Changed the error text if there are no files found

need wt=xml in the servlet request

This patch should be much better.
Still formats it in a table and does a better job checking if the value of the xml is the expected value. Directories are not listed.

Smaller and leaner

Tested extensively on both Apache Solr 1.4 and 3.4
Committed

Thanks!

Would seem like the wt=xml part at least needs to be backported to 6.x?

This might do it for d6

Yes, let's test it, but I think that's all that's required.

Tested on D6 and works for solr 1.4 and 3.4

https://img.skitch.com/20111116-c9fe4ceu4jn5p4h9n27q2fb3qm.jpg (3.4)
https://img.skitch.com/20111116-895efkk7d642ew6pkgn18wwpi5.jpg (1.4)

And committed for 6.x also