flatrate does not obey override

Copying from my duplicate issue..

I was having an issue with overriding flat rate prices using the prices specified in the actual product nodes. The flaterate array was not being set on the products in my cart and I noticed that while uc_flatrate implements hook_node_load to setup the flatrate array, in uc_cart_get_contents when it calls node_load, it then manually copies off the loaded fields to a custom object like so:

      $product = node_load($item->nid);
      $item->cost = $product->cost;
      $item->price = $product->sell_price;

The flatrate member is not in that list, so therefor it's never copied to the actual item that is added to your cart.

To fix this, I added this to uc_flatrate.module:

function uc_flatrate_uc_cart_item($op, $item) {
  switch ($op) {
    case 'load':
      $product = node_load($item->nid);
      if (isset($product->flatrate)) {
        $item->flatrate = $product->flatrate;
      }
      break;
  }
}

It seems silly to call node_load again, but it was the easiest way to get up and running. I didn't make an actual patch as I don't know if this is the preferred way to fix this.

I don't think either solution corrects the root problem. This works properly in Ubercart 6.x-2.x. The flatrate data gets attached to the product object during a node_load(), so the question is where is the missing node_load() in Ubercart 7.x-3.x?

Note that it's not just the flatrate module that's affected - it's also weightquote and all the other shipping modules, which implies the real problem is somewhere in uc_quote. And that's where it should be fixed, so it fixes all the shipping methods.

Try this. I'm not too thrilled with the code - it could probably be done more efficiently with a re-write - but it's a straight port of code out of the D6 version of uc_quote.module so it should have "known" behavior.

Hey TR,

The fix works for me. My patch still had another issue I found out and ended up sleeping on, and then I woke up to your fix, thanks!

Marked #1200616: product flat rate quote not overriding the default rate as duplicate

Committed #3.

Hello,

I just installed 7.x-3.0 beta 4 and noticed that the patch attached to comment #3 was not added. I also checked 7.x-3.x-dev and it wasn't added there either. I just thought I would let you know.

Thanks,
Paul

Not sure what happened there, but it's definitely committed now: http://drupalcode.org/project/ubercart.git/commitdiff/9807480

The fix is not present in beta4, but is in -dev and will be in the next recommended release.

I just loaded Dev and it is still not obeying the override.

I'm running 7.x-3.0-beta4 and it does have the latest patch. I have multiple flat rate shipping levels. With that setup, and with the patch in place (beta4 has the patch included), the flat rate override does work.