Download & Extend
Mongodb » Issues

Backport cache to D6

Posted by msonnabaum on March 19, 2011 at 5:35am
Project:Mongodb
Version:6.x-1.x-dev
Component:Cache
Category:task
Priority:normal
Assigned:Unassigned
Status:needs review

Issue Summary

Patch attached.

Seems to work ok in my limited testing.

AttachmentSizeStatusTest resultOperations
mongo_cache_backport.patch2.37 KBTest request sentNoneView details
Login or register to post comments

Comments

#1

Posted by crea on June 5, 2011 at 6:35pm

I suggest to remove REQUEST_TIME definition in favor of #1179402: Define REQUEST_TIME for backports. Its also used in many other places.

#2

Posted by crea on June 5, 2011 at 6:56pm
Category:feature request» task
Status:active» needs review

Attached patch depends on #1179402: Define REQUEST_TIME for backports

AttachmentSizeStatusTest resultOperations
mongodb_cache_1098268.patch1.99 KBTest request sentNoneView details

#3

Posted by crea on June 6, 2011 at 8:43am

Cleaner patch

AttachmentSizeStatusTest resultOperations
mongodb_cache_1098268.patch1.99 KBTest request sentNoneView details

#4

Posted by crea on June 26, 2011 at 5:14am
Status:needs review» needs work

#5

Posted by crea on June 26, 2011 at 6:40am
Status:needs work» needs review

Updated patch: no REQUEST_TIME dependency

AttachmentSizeStatusTest resultOperations
mongodb_cache_1098268_5.patch7.87 KBTest request sentNoneView details

#6

Posted by dob_ on August 28, 2011 at 11:01am

Patch seems not to work for me.

I tried it with a pressflow 6.20 installation.

cd sites/all/modules/mongodb
patch -p1 < patchfile.patch

Created the directory automatically.
Then i was able to activate the module.

Added these to my settings:

$conf['mongodb_connections'] = array(
'mongohost' => array('host' => 'localhost', 'db' => 'mydb'),
);

$conf['mongodb_collections'] = array(
'watchdog' => 'mongohost',
'session' => 'mongohost',
'cache' => 'mongohost',
);

Watchdog messages are written to mydb. Sessions and Cache not.

Any ideas?

#7

Posted by crea on August 28, 2011 at 11:17am

In this issue only cache is discussed. Sessions are discussed in different issue.
To use this you need something like this:

$conf['mongodb_connections'] = array('default' => array('host' => 'localhost', 'db' => 'drupal'));
$conf['cache_inc']   = './sites/all/modules/mongodb/mongodb_cache/mongodb_cache.inc';

#8

Posted by dob_ on August 28, 2011 at 12:01pm

Alright, that was the point.

Now i get this error:

MongoException: non-utf8 string:

#9

Posted by dob_ on August 28, 2011 at 12:14pm

Changed code after line 149 and checked if the data string is valid UTF-8.

if(mb_detect_encoding($entry['data'], 'UTF-8', true)) {
$collection = mongodb_collection($this->bin);
$collection->save($entry);
}

#10

Posted by crea on August 28, 2011 at 1:02pm

There's an issue here about using mongo binary type for cache.

#11

Posted by dob_ on August 28, 2011 at 2:54pm

Thanks.
My changes to use binary storage.....

131,132c131,136
< if ($cache->serialized) {
< $cache->data = unserialize($cache->data);
---
> if($cache->binary && $cache->serialized) {
> $cache->data = unserialize($cache->data->bin);
> } else if(!$cache->binary && $cache->serialized){
> $cache->data = unserialize($cache->data);
> } else {
> $cache->data = $cache->data->bin;
134c138
<
---
>
145a150
> 'binary' => true,
147c152
< 'data' => $scalar ? $data : serialize($data),
---
> 'data' => $scalar ? $data : serialize($data),
149c154
<
---
> $entry['data'] = new MongoBinData($entry['data']);
151d155
<

#12

Posted by makara on October 24, 2011 at 9:06am

Updated the patch:

AttachmentSizeStatusTest resultOperations
1098268_mongodb_cache_6.patch8.41 KBTest request sentNoneView details

#13

Posted by makara on October 27, 2011 at 2:25pm

Fixed patch:

  • Drupal 6 sets HTTP headers in the cache.
AttachmentSizeStatusTest resultOperations
1098268_mongodb_cache_7.patch8.48 KBTest request sentNoneView details

#14

Posted by crea on October 28, 2011 at 1:23am

There's no need to validate if the cache data is valid utf. Just use binary type everywhere