You can't select "no pager" on the first page of the views create form

This patch removes the element validators (for positive integers) in order to also allow 0 as input value. However it might be good to consider adding different validators (0 or positive integer) in the future. I also added a new checkbox to the wizard ("Use a pager"). This way we can produce every combination of pager / non-pager blocks or pages. For example: Setting "10" in items_per_page and unchecking "Use a pager" will cause the pager to be set to type = "some" with 10 items. Setting items_per_page to 0 and unchecking "Use a pager" will cause the pager to be set to "none" and thus show all items.

In my opinion, this is not a bug - just a design decision, no? The wizard isn't supposed to cover all possible use cases of Views (that's what the later configuration screen is for), just the most common ones.

So the question is whether it's worth the cognitive burden of adding more settings to this page in order to support additional use cases. I'm not sure, but it seems to me like a view that can (potentially) grow to an arbitrarily large number of items being displayed per page is often a bad idea, and not what people usually want. And a view with a fixed number of items (no pager) is not too common for page displays (but is for blocks). So maybe the 80% use case is actually having a pager for page displays, and having a fixed number of items (no pager) for blocks - which is not what's there now, but also not what's proposed here either.

Either way...

This patch removes the element validators (for positive integers) in order to also allow 0 as input value. However it might be good to consider adding different validators (0 or positive integer) in the future.

I think "in the future" would really need to be "as part of this patch"... The validation is there for a reason :)

In that case their would have to be a different validator because _element_validate_integer_positive doesn't allow 0 as a value, naturally. Also, it should be considered wether such a validator should be added to the pager configuration on the actual view configuration page. At the moment the validator only exists for the wizard.

I agree that the patch isn't a real solution, however this is bigger than a simple design decision. I would wager that it's fairly common to have a unlimited number of items displaying on a page.

Why not simply allow 0 to mean unlimited like it has for years. It's very much the expected behavior and wont take up any more space on this page or even change the way it looks. If not allowing 0 covers 80% of use cases (ball park), allowing a zero only increases the usability percentage without taking anything away.

Please? :-)

I installed jCarousel 7.x-2.4-alpha3 and Views 7.x-3.0-beta3 (the last "Recommended releases" to date). Although it's not documented yet, it seems I'm supposed to choose in "Show": "Module/Theme/Theme engine". Then if I select "Create a block", and, in "Display format": "jCarousel", and then click on "Save and exit" I get the error message “The jCarousel style cannot be used with a pager. Disable the 'Use pager' option for this display. ”, repeated twice, with no explanation about where to disable that option. This message is in-understandable since the word "pager" appears nowhere else on the page. But it seems jCarousel will not work with Views 3 until this bug be fixed, will it? Moreover, the error message should be more explicit.
See http://drupal.org/files/issues/Views_jCarousel_error.png
and jCarousel bug http://drupal.org/node/1144468 .

This is stupid behaviour by the jCarousel module since (on the Wizard) you don't have the option "No pager", so I get your point here... However this is NOT a View problem, its a jCarousel problem. This Issue covers a whole different problem. You should submit your Issue to the jCarousel Issue queue. For now ... in order to avoid the problem you ran into ... dont select jCarousel on the Wizard, instead select any other Display plugin, proceed to the "actual" Views UI, disable the Pager there and then select jCarousel as your Display plugin... That should work.

This patch sadly needs a rerole based on #1178128: Views is using a "non-public" validation function from fields module

The rerole could just rename the function introduced in the other issue and use it for the validation.

Here is a rerole.

Works nicely for me.

Thanks commited to 7.x-3.x