After installing OGURA I got the following error when I rebuilt content access permissions:

Parameter 2 to og_user_roles_access_og_access_grants_alter() expected to be a reference, value given in /var/www/html/drupal/includes/common.inc on line 2892.

The error apparently is due to cahnges in php 5.3. See http://drupal.org/node/600106.

I fixed it by changing og_user_role_access.module

function og_user_roles_access_og_access_grants_alter(&$grants, &$node) {

to

function og_user_roles_access_og_access_grants_alter(&$grants, $node) {
CommentFileSizeAuthor
#1 og_user_roles_access.module-pass-by-reference.patch304 bytesMaxF

Comments

MaxF’s picture

MaxF commented
Priority: Normal » Critical
StatusFileSize
new og_user_roles_access.module-pass-by-reference.patch304 bytes

I second the above opinion, rsbecker. Your patch works for me, as well. I attached it for convenience.

This is a security-critical bug, as it appears to leave some nodes open to unwanted roles, thus the promotion in Priority.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Priority: Critical » Normal

I see no reason that this might be security related.

burgs’s picture

burgs commented
Status: Active » Reviewed & tested by the community

I've tested this, and it seems to solve the problem with drupal 6. If we could get this patch committed, that would be appreciated.

Thanks.

miro_dietiker’s picture

miro_dietiker
Location Switzerland
commented
Status: Reviewed & tested by the community » Fixed

Fixed.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.