Drupal 5 port
tknospdr - January 16, 2007 - 13:27
| Project: | LinksDB |
| Version: | HEAD |
| Component: | Miscellaneous |
| Category: | task |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | patch (code needs review) |
Description
Any idea on when we might get a D5 version of this module?
Thanks,
David
#1
Please?? The HEAD version won't even show up in the modules list on my test R5.1 version site. This is the last module I'm waiting on to move my production site from 4x to 5x.
Thanks,
David
http://www.FloridaPets.org
#2
Iv got the same problem. Look at this page : http://drupal.org/node/107099
I'm still waiting.....
#3
Is the developer of the mod even around anymore? :(
Thanks,
David
http://www.FloridaPets.org
#4
I've marked a few issues as duplicates of this. I also would like to see this module ported to Drupal 5.x, but realise there's nobody interested enough to actually do it. Perhaps it's worth considering the weblinks module which does exist in 5.x?
#5
The weblinks mod has some shortcomings that this mod doesn't. I just wish someone would update it.
#6
I need this module on a couple of new sites my company will be developing over April, so if no else has started the port by then, I'll look to do it.
Realistically I should hopefully have some time to spend on this towards mid/end April, has anyone else made any efforts getting this ported to drupal 5 yet? I don't want to duplicate someone else's work.
Cheers,
Phil.
UK Digital Graphics Ltd (www.ukdg.net)
#7
Not yet.
#8
I've managed to take at look at the port, and seem to have it running ok under a drupal clean 5.1 install.
We don't use all the features, so I can't be sure it's 100% complete, but should at least allow users to make use of the module under drupal 5.x.
No database changes have been made so it 'should' work fine with upgrades, but I have'nt tried it on anything apart from a clean install, so as with anything like this please make sure you BACKUP YOUR DATA first, before trying out this module.
I've attached the patch first, which has the main changes (apart from the .info file). I'll then attach the info file & finally a zip of my version of the module for those of you who don't use patch files.
Let me know how you go with this, & if anything needs fixing still. Theirs a few minor items left on my todo list for it, but I'd rather test the current changs first.
Phil.
UK Digital Graphics Ltd (www.ukdg.net)
#9
Ok, so we can't attach .info/.zip files to posts.
Here's the code for the linksdb.info file, you can create it yourself:
name = LinksDBdescription = Maintains a database of links.
#10
And finally, here's a link to a zipped version of the module:
http://ukdg.net/sites/default/files/drupal/linksdb-drupal5-v1.x-dev-2007...
And the notes I've made on the changes made:
Notes:
No changes were made to the database, & so the 'linksdb.install', 'linksdb.mysql' & 'upgrade.sql' files have all been left alone.
- Added a linkdb.info file
- Upated form handling - takes into account the new 'drupal_get_form' functionality.
Added a '_form' wrapper to all original form functions, & altered the name of the '_submit' function to work with the changes.
Note: their may be a better way to handle these, but this works for now, perhaps use a hook_menu 'callback' of 'drupal_get_form'?
Updated form functions:
- linksdb_report_form
- linksdb_deadlinks_form
- linksdb_moderate_form
- linksdb_display_form
- linksdb_suggest
- linksdb_show_all
- Altered the 'linksdb_settings' to use the menu_hook system
- Altered 'theme_links' to use the new 'theme_form_element' arg listing
- Altered some code formatting to be more inline with drupal coding standards (http://drupal.org/node/318)
TODO:
- find out what linksdb_show_all is meant for - admin? public use?
- check if the form wrapper functions are needed, or 'callback' => 'drupal_get_form' could be used in the menu_hook instead.
- add an 'uninstall' hook to clear the database tables.
#11
IT WORKS PERFECTLY!!!!!! Thank you!
One thing you might want to do is fix the permissions on the files in your .zip file though. I got Drupal errors after I put the module in place until I fixed all the perms.
Thanks,
David
http://www.FloridaPets.org
#12
Hi David,
Thanks for testing it out & giving your feedback. Glad its working ok for you apart from the file permissions.
The zip was originally created on a windows machine & was working fine on our Linux dev server, but permissions may have got altered by our Samba share when copying it across during testing. I have updated the zip in the link above by re-zipping it (on Linux this time) with read permission for all, which should hopefully fix the issue you mentioned. Let me know if not.
Also updated the status of this issue as I forgot before.
Regards,
Phil.
UK Digital Graphics Ltd (www.ukdg.net)
#13
Hey Phil,
Works fine here!
Had a small glitch when i clicked "Show more"... so i commented out the line 344 in linksdb.module
//drupal_set_message(" -> " . print_r($cat, true), 'debug');
Thanks,
Seb
#14
Hi Seb,
Glad its working for you. Good work on spotting that debug message, sorry, must have forgotten to remove it at the time.
Will try & re-zip the file with that message removed. I'll post an update here when that's done. (A little busy at the moment, so will have to see when I get a few spare moments to do it).
Regards,
Phil
UK Digital Graphics Ltd (www.ukdg.net)
#15
Hello all.
Sorry I have let this module fall by the wayside a bit.
Anyhoo - I have incorporated Phil's patch (*thanks phil*) into a new drupal-5 branch which should appear later on for download.
Matt