Posted by arski on March 19, 2011 at 5:48pm
2 followers
Jump to:
| Project: | OG Join Role |
| Version: | 6.x-1.x-dev |
| Component: | Code |
| Category: | bug report |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | reviewed & tested by the community |
Issue Summary
Hey there,
I've recently discovered a couple of syntax issues with the small .js files inside your module. There are two particular ones:
1. Things like $("a[@href*=og/subscribe]") should be without the @ (deprecated usage), see http://drupal.org/node/412626 as well. This comes up twice in the code.
2. The .contains function has only been added in jQuery 1.4, while most D6 sites run some 1.3 version (in the lucky case where jQuery_update is even installed). The safer way is the :contains selector http://api.jquery.com/contains-selector/ sotheli = $("div[@id^=block-og] li").contains("in order to post into this group");
should be replaced withtheli = $("div[id^=block-og] li:contains('in order to post into this group')");
Cheers
Comments
#1
arski,
Thanks for the great tips - I've updated and committed the changes (http://drupal.org/commitlog/commit/3100/0c2443a6928020234df749ee792470a3...).
-mike
#2
Cool stuff.
BTW. Are you planning on releasing a kind of stable release someday? It seems that the module is in -dev only mode for quite a while now with no open issues.
Cheers
#3
arski,
Yeah, I probably should. The reason I haven't yet is because not too many people use it, and I don't have a good feel for how "stable" it is. I guess that the lack of open issues in the queue is one indicator...
I'd love to hear from people using it that it does what it's supposed to do with no ill effects (or am I being delusional?) I'll re-open this case in hopes of getting some feedback.
-mike
#4
hmm, sounds good, only I wouldn't expect anyone to check some random issue.. maybe it would be a good idea to create a new to-do task and also link it explicitly from the project page?
And as you said, as there are no issues posted, the 50 users seem to be happy.. so.. considering how small the module is its probably stable enough for at least a beta or something ;)