LDAP Map

I've done an initial review of the module and posted a few issues in the sandbox queue.

I'm using ldap 7.x-1.0-beta1 and as I couldn't get provisioning works with my install, I decided to use ldap_map. However fields were not populated at all but the modules was able to fetch the data in "ATTRIBUTE LOOKUP" tab. So after investigation I found that line 48 of ldap_map.module is wrong :

$value = $servers[$field['server']]->search($filter, NULL, $attribs);

while this one works nicely

$value = $servers[$field['server']]->search(NULL, $filter, $attribs);

Hope it'll help...

This isn't fixed as this is a project application issue that hasn't been resolved. Any bugs or patches against the module should be filed in the sandbox project at http://drupal.org/project/issues/1098958

This should probably remain normal, and as mentioned bug reports should be filed in the project issue queue. This particular issue is relevant only to the application, and not the module itself.

Great! Just for future reference the issue queue here works a bit differently. Ay time you've fixed an issue setting it back to needs review will notify reviewers that your application us ready to continue the process.

If you are simply improving upon another module, could this be better contributed as a patch to that modul to improve it rather than separating the two?

There are a number of ldap modules for d7 for data synching. Ldap profile is the one for synching ldap entry data to ldap user data. Its in the 7.x-2.x branch of the ldap project.

In the ldap project I moved the ldap data modules (ldap profile, ldap data, ldap provision, ldap synch, etc.) from the 7.x-1.x branch to the future 7.x-2.x branch simply because there was no follow through on patch requests and bug reports by the people who were working on them. They also lacked thoroughness such as simpletests, exportables/features support, etc.

It would be great if you could take a more assertive role in the ldap profile module, regardless of whether it stays within the ldap project or this project application is renamed ldap_profile, which is what this functionality was called in drupal 6. The problem with it being in the ldap project is it means we all need to be in the same release cycles. The good side of it being there is it makes usability simpler for the end user.

Another problem within the various ldap data modules is a general lack of a coherent architecture for synching ldap data to drupal structures. Without that there will need to be an ldap module for every drupal data type such as Ldap profile, ldap node, ldap taxononmy, etc. I've tried to have some tools in the ldap project to help provide a common code base to leverage (ldap_query, ldap_server, 2 ldap feeds fetchers, and ldap feeds parser).

@doana: do you want to move your efforts to the ldap project or do you still want to make this a separate project?

All the fields are ported into the database perfectly so I think it will good ldap maintainers support.

This issue is not fixed, see http://drupal.org/node/532400

There are several indentation issues and spacing issues. (please use this tool to verify all theses types of errors http://ventral.org/pareview)
Are the database fields all 255 characters long? I feel that's way too big for those fields.
Your project page is basically empty, please consider enhancing it. http://drupal.org/node/997024

minor issues