Saw the following notice in my watchdog:

message PDOException: SQLSTATE[22001]: String data, right truncated: 1406 Data too long for column 'parent' at row 1: INSERT INTO {browscap_statistics} (parent, counter, is_crawler) VALUES (:db_insert_placeholder_0, :db_insert_placeholder_1, :db_insert_placeholder_2); Array ( [:db_insert_placeholder_0] => Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.0; Trident/4.0; GTB6.6; chromeframe/10.0.648.151; SLCC1; .NET CLR 2.0.50727; Media Center PC 5.0; eSobiSubscriber 2.0.4.16; .NET CLR 3.5.30729; InfoPath.2; .NET CLR 3.0.30729; .NET CLR 1.1.4322; .NET4.0C; AskTbBLPV5/5.9.1.14019) [:db_insert_placeholder_1] => 1 [:db_insert_placeholder_2] => 1 ) in browscap_exit() (line 98 of /var/www/sites/all/modules/browscap/browscap.module).
CommentFileSizeAuthor
#7 browscap_exit-truncate_HTTP_USER_AGENT_to_255_characters-1099378-7.patch657 bytesdevin carlson
#1 browscap_exit-truncate_HTTP_USER_AGENT_to_255_characters-1099378-1.patch856 bytespillarsdotnet

Comments

pillarsdotnet’s picture

pillarsdotnet commented
StatusFileSize
new browscap_exit-truncate_HTTP_USER_AGENT_to_255_characters-1099378-1.patch856 bytes

Attached patch fixes the problem by truncating HTTP_USER_AGENT string to 255 characters.

pillarsdotnet’s picture

pillarsdotnet commented

bump.

troybthompson’s picture

troybthompson commented
Status: Active » Reviewed & tested by the community

Confirmed that this patch fixes the same error one of my users was getting.

bernard63’s picture

bernard63 commented

Hi,
I am a French Drupal beginner (sorry for my language)
I have the same problem with the Agregator module.
Is HTTP_USER_AGENT a phpmyadmin value for browscape.module, or where is it ?
I search in all direction to resolve my problem.
Thank you for a response.
Bernard

devin carlson’s picture

devin carlson commented

The patch in #1 applies cleanly and fixes the issue of having user agent names which are longer than the maximum size allowed by the parent column (255 characters).

The issue occurs because browscap_exit successfully truncates $browser['parent'] when a default browser is not found but does not truncate $_SERVER['HTTP_USER_AGENT'] when a default browser is found.

bernard63, for issues concerning maximum data lengths and the Aggregator module, please see:

devin carlson’s picture

devin carlson commented
Status: Reviewed & tested by the community » Fixed

Committed to 7.x-1.x.

devin carlson’s picture

devin carlson commented
Version: 7.x-1.x-dev » 6.x-1.x-dev
Assigned: Unassigned » devin carlson
Status: Fixed » Needs review
StatusFileSize
new browscap_exit-truncate_HTTP_USER_AGENT_to_255_characters-1099378-7.patch657 bytes

Backport of #1.

devin carlson’s picture

devin carlson commented
Status: Needs review » Fixed

Committed to 6.x-1.x.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.