Hi,

I've adapted the module for 5.0. Could you check it and, if possible, branch the module for Drupal 5 so we can have a D5 branch ?

Since this is so small, I'm attaching a tarball of the whole 5.0 module version, ready to be installed and tested.

CommentFileSizeAuthor
adminrss.tar11 KBfgm

Comments

Yazz’s picture

Yazz commented

Appears to install fine but nothing appears in the feeds it creates. Is it suppose to be able to show a feed if someone submits a new story node or page node?

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

Note that you must first set it up with a password and use the specific RSS URL containing the password to see anything.

simbot’s picture

simbot commented

I think by default the key should be a long random string, so in adminrss_admin_settings() I've added:

$key = variable_get('adminrss_key', '');
if ($key == ''){
$key = md5(uniqid(rand(), true));
variable_set('adminrss_key', $key);
}

This should be quite secure as a default.

fgm’s picture

fgm
Primary language French
Location Paris, France
commented

The problem becomes: if it's random, how does the webmaster know what the key is ? Without knowledge of the key, the module is useless, IMHO.

Note that you didn't submit a patch, so maybe I'm missing something here.

simbot’s picture

simbot commented
Assigned: Unassigned » simbot
Status: Needs review » Closed (fixed)

True, the admin still has to go to the module to get the feed URLs. but giving a secure default I think is a good idea.

I've applied your patch, and mine to CVS.