If flag_friend_message_form() is rendered without a destination, the following warning appears:

Notice: Undefined index: destination in flag_friend_message_form() (line 378 of /path/to/drupal/sites/all/modules/flag_friend/flag_friend.module).
CommentFileSizeAuthor
#1 1099768-no_destination.patch1001 bytesshawn dearmond

Comments

shawn dearmond’s picture

shawn dearmond commented
Status: Active » Needs review
StatusFileSize
new 1099768-no_destination.patch1001 bytes

Patch attached.

sirkitree’s picture

sirkitree commented
Status: Needs review » Fixed

Committed, thank you! http://drupalcode.org/project/flag_friend.git/commitdiff/9988c1f58002ff4...

As a side note, wondering how you came across this one.

Also, when creating your patches it would help me out if you could use the --relative parameter.

shawn dearmond’s picture

shawn dearmond commented

I came across it because when I was building #1099756: Create tests, the test was posting to forms without the "?destination=..." and I was getting all kinds of exceptions.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.