UberInvoice allows users who are running a Drupal multi-site configuration to override the Ubercart core invoice templates without showing custom invoice templates across multiple sites. For users running one site, it reduces the hassle of overriding Ubercarts core invoice templates.

It is a simple module that overrides where ubercart looks for its templates and includes two predefined custom templates for users to use / build upon.

The reason for making the module was a lot of people having issues getting instructional code at, http://www.ubercart.org/docs/developer/17385/changing_invoice_templates_..., working and if we can build up many styles of Invoice templates this may help the community.

Comments

md2’s picture

md2 commented

Sorry, missing sandbox URL

http://drupal.org/sandbox/markdavies/1088200

tr’s picture

tr commented
Status: Active » Needs review
jgraham’s picture

jgraham commented
Component: new project application » module
Status: Needs review » Needs work
Issue tags: +pdx-code-review

Hi,

I just took a look at your module and reviewed the linked ubercart documentation. Judging from the activity (over 60 comments!) This certainly looks like it is targeting a problem area within the ubercart space.

However this looks like a module stub to me. While this should be made available I don't think it is deserving of its own project entry on drupal.org.

Points of interest;
1. In uber_invoice.module it is suggested that the end-user adjust the array. Users who download and install modules should not be expected to edit code to get the desired functionality. This should be managed via config or admin settings.
2. Users who download and install this module are also expected to edit or add several .tpl.php files.

In summary this really feels like a module stub bordering on a documentation issue. That is, this should be a generic module instead of uber_invoice I would recommend MODULENAME.

Perhaps a screencast documenting how to accomplish this would help clarify the difficult steps.

md2’s picture

md2 commented

Hi Jeff,

I totally agree that the editing of the array is out of place.
1. I've implemented an admin page which takes the names of the two templates you would like to use, one for admin, one for customer.

2. The form defaults to two predefined invoice templates, uberadmin and ubercustomer. The module should allow users to edit these straight out of the box. If they wish to add a different template the module will check that it exists in the module directory before allowing the form to save. I don't think automatically creating the file for them is a good idea.

I kept the ubercart default invoice templates in the module directory for users to reference, but I'm thinking they should be removed, would you agree?

I wasn't sure what you meant by

"That is, this should be a generic module instead of uber_invoice I would recommend MODULENAME."

but I've removed the _ in the module name as I don't think its good practice, so the module name is now "uberinvoice".

md2’s picture

md2 commented
Status: Needs work » Needs review

marking for review

klausi’s picture

klausi
he/him||they/them
Primary language German
Location 🇦🇹 Vienna
commented
Status: Needs review » Needs work

* project page is too short. More info please.
* remove all old CVS $Id tags from all files
* wrong indentation in uberinvoice_uc_invoice_templates() and elsewhere, use 2 spaces per level, see http://drupal.org/node/318#indenting
* "Setup admin section to allow users to configure uberinvoice" comment sentences should end with a "."

Dubber Dan’s picture

Dubber Dan commented

This looks and sounds really useful. Is it ready for use yet?

md2’s picture

md2 commented

Hi Dubber Dan,
I'm need to fix the issues in #6 and resubmit for approval. The module does work as it stands, download it via git instructions and report any issues in the issues queue.

Kind Regards,
Mark

misc’s picture

misc commented

@md2 has been contacted to ask if the application is abandoned.

After ten weeks with a status of needs work: the applicant may be contacted by a reviewer to determine whether the application was indeed abandoned. The action taken by the reviewer should be documented in the project application issue.

http://drupal.org/node/894256

misc’s picture

misc commented
Status: Needs work » Closed (won't fix)

The application has been closed. If you would like to reopen it, you are free to do so.
See http://drupal.org/node/894256#abandonedtwoweekscontact