Invoke hook when validating email

Notwithstanding the function being called logintoboggan_validate_email, it feels like the operation here should be called update, and not validate. That would seem more consistent with the operator usage for hook_user.

This also feels very specific. Isn't the hole closed if you disallow immediate login?

are we sure we want to use a structure similar to hook_user? i'm wondering if a specific hook name w/o the $op arg would be better in this case or not. thoughts?

For that matter, would it work to just invoke the existing hook_user mechanism with the 'update' $op? At an abstract level, it makes sense to say that hook_user('update',.. should be called any time a user account is changed, and this is certain such a case.

+1. i like that approach much better. user module is a required core module, so invoking a user module hook in LT should always work.

do you have a patch for comment #5 or #6 ?

can't you add something to the $user object before you invoke the hook?

$user->logintoboggan_email_validated = TRUE;

something like that, maybe?

there might be a better way to do it. just thinking out loud...

Here's the same patch for drupal 5 branch.

I tested patch from #10 and it worked fine on latest 4.7.

im guessing $account->logintoboggan_email_validated only is set when they validate as this is not placed as a saved user variable

function um_helper_user($op, &$edit, &$account, $category = NULL) {
  switch($op) {
    case 'update':
      // implements http://drupal.org/node/110026
      if ( $account->logintoboggan_email_validated ) {
        // do something
      }
    break;
  }
}

im guessing $account->logintoboggan_email_validated only is set when they validate as this is not placed as a saved user variable

correct. we're not even putting that variable into the global user object, so it's only really available to modules making use of the 'update' op of hook_user. i like it being this insulated.

i do have a few minor concerns about the current patch:

• the only other contrib module that invokes this update hook is invite module, and it's handled like this:
  

  // Notify other modules of changed user
  $edit = array('roles' => $targets);
  user_module_invoke('update', $edit, $invitee);
  

  perhaps we should also put logintoboggan_email_validated into the $edit array as opposed to the user object?? not sure about that, just speculating...

• the main use of the hook_user() 'update' op is for saving the user editing form at user/x/edit. it's possible that some modules responding to this hook will have problems with an empty $edit array. it would ultimately be a problem for the other modules to work out, since they wouldn't be using strict enough code for their 'update' op, but expect possible breakage in other modules if we make this change.

thoughts on these?

committed to drupal 5 and HEAD. i won't add this to 4.7, as it's a feature and not a bugfix.