domain_url_rewrite_outbound_alter() might not fire hook_domainpath()

This is a domain-sensitive version of Path module, targeted at nodes. Domain Access itself doesn't handle anything but nodes ATM, so this module is targeted at the node form.

However, patches that add targeted functionality for non-node links would be great. The database structure supports it, we just need the UI piece.

See also http://drupal.org/sandbox/agentrickard/1080434.

That should be the current behavior. domain_url_rewrite_outbound_alter() should invoke domain_path_domainpath() to rewrite the url properly.

Are you working in 6 or 7? In d6 you might need the url_alter module.

No. That approach is wrong. Domain Access itself handles hook_url_outbound_alter() in both D6 and D7. It then fires an internal hook to domain_path. See the domain access api and hook_domainpath().

If it's failing for you as-is in D7, something else is wrong. This is either a support issue or a bug. Not a feature request, because this is the default feature of the entire module.

If you are having d6 problems, we should address in the d6 backport issue.

See the last logic statement in domain_url_outbound_alter().

     // We may have to implement hook_domainpath().
    if (!isset($path_rewrite)) {
      $path_rewrite = count(_domain_path_modules());
    }
    // Allow path changes, if needed.
    if ($path_rewrite > 0 && $path != '') {
      $path = domain_path($target_domain_id, $original_path, isset($options['language']) ? $options['language']->language : '');
    }

We need to move the final IF block out of the one it's in, then. We never noticed because the above conditions have been true on all the current sites.

Try moving this part:

    // We may have to refactor this for D7.
    if (!isset($path_rewrite)) {
      $path_rewrite = count(_domain_path_modules());
    }
    // Allow path changes, if needed. This changed significantly in D7.
    if ($path_rewrite > 0 && $path != '') {
      domain_path($target_domain_id, $path, $options, $original_path);
    }
  }
}

To:

  }
  // We may have to refactor this for D7.
  if (!isset($path_rewrite)) {
    $path_rewrite = count(_domain_path_modules());
  }
  // Allow path changes, if needed. This changed significantly in D7.
  if ($path_rewrite > 0 && $path != '') {
    domain_path($target_domain_id, $path, $options, $original_path);
  }
}

This would be the first time I've ever seen that hook used outside the current logic. If that works, then it's a bug in the main module.

Also affects 7.x

Patch against Domain Access 6.x.2

That won't actually work, since $target_domain_id might not be set.

Yes, that would. (I came up with the same solution this morning; I just needed some time to think, since I was really busy yesterday.) It also works if we just move the $target_domain_id outside of the first IF loop.

The theory here is that we only want domain modules to implement one instance of url rewrite.

Here's a proper patch for D6.

Patch from #15 is working.

Thanks! Are you using one of the modules (Domain Path or Domain URL) that need it?

Looks good and clears the way for a Domain Path release on D6.

Tested with both Domain Path and table prefixing in D6, btw.

Looks like a cross-post. This is fixed in all versions.