Come together with the global Drupal community in Rotterdam, 28 Sept – 1 Oct 2026. Sessions, contribution, connection, and Early Bird savings until 8 June.I thought when the new CVS rights went into effect I lost access to this project, but apparently I didn't, so I guess I'll volunteer to do the 5.0 upgrade and close some of the open bugs in the process.
| Comment | File | Size | Author |
|---|---|---|---|
| #21 | troll_drupal5_upgrade4.patch | 17.6 KB | mcarbone |
| #20 | troll_drupal5_upgrade3.patch | 16.8 KB | mcarbone |
| #18 | troll_drupal5_upgrade2.patch | 15.48 KB | mcarbone |
| #15 | troll_drupal5_upgrade1.patch | 25.05 KB | mcarbone |
| #8 | troll_drupal5_upgrade.patch | 23.49 KB | mcarbone |
Comments
Comment #1
Marandb commentedThis is awesome news! I have a big site upgrade that I am waiting for Troll to complete.
I can help test in any way I can.
Thank you,
Marandb
Comment #2
deekayen commentedReminding me might not hurt. This had already fallen off my list, but I'll put some time into it right now.
Comment #3
deekayen commentedI just made several form updates so they don't make apache spew internal errors anymore. Still not ready for testing unless someone wants to help patch stuff. Next opportunity for me to work on this is Feb 1.
Comment #4
Marandb commentedThanks again for your work on this. Unfortunately I am not much help on the coding side.
As soon as there is a testable module I will begin testing. Keep us informed.
Thanks,
Marandb
www.minifigcustomizationnetwork.com
Comment #5
deekayen commentedI think the blacklist functions work (the part I contributed). The original troll functions for functions related to searching and banning users is still broken.
Comment #6
chazz commentedHello,
How works going ?
Is it avaible now for D5 ?
Comment #7
deekayen commentedMarco expressed interest in working on this, so I'll unassign myself for now since it'll be at least a week before I get back to this module. There are a few bugs that are show-stoppers, but shouldn't really take much effort in terms of man-hours to resolve.
Comment #8
mcarbone commentedOK, here's a patch for upgrading troll for Drupal 5.x. I did as much testing as I could, but of course more is always welcome.
Oh, and here's a .info file: http://crazymonk.org/troll.info -- linked externally because drupal.org won't let me post anything with a .info extension.
Comment #9
mcarbone commentedOne small issue I didn't address. The module puts the default redirection for blocked users to modules/troll/blocked.html. Problem is that it is now considered bad practice to put contrib modules in modules. They should instead be in sites/all/modules or sites/*/modules. Of course, that means the location of blocked.html is uncertain.
I'm not sure adding a
drupal_get_path('module', 'troll')is the way to go here either, because it would prevent the user from having an alternative blocked.html anywhere else. Thoughts?
Comment #10
deekayen commentedRe: #8 - I didn't test the patch, just read through it. I noticed most appeared to be just formatting cleanup. In two places you switched % to ! in t() replacement, but for %username, you left it alone. Any particular reason?
Re: #9 - I haven't put much thought into it, but my initial reaction is stuck on what's wrong with what you said - just replace the 'modules/troll/blocked.html' with drupal_get_path, but maybe add a ternary to test empty() on the troll_ip_ban_redirect variable so people can set the variable field to blank to go back to default.
Comment #11
mcarbone commented#8: They were hard-coded URLs, so I didn't want them to go through check_plain. Everything else is text, and fine as is.
#9: Good call. I didn't think much about it before making that comment, obviously.
Comment #12
chazz commentedSo it is working properly for Drupal 5 ?
Comment #13
deekayen commented#12: When mcarbone updates the patch with #9, I'll commit it, then you can test it, and if you like it and I like it, I'll tag it as 5.x-1.0.
Comment #14
chazz commentedOk, so we are waiting ;)
Comment #15
mcarbone commentedHere it is, with #9 implemented. Test it out, let me know if there are any other problems.
Comment #16
deekayen commentedIt looks like your patch is diffed against an old version of the module; I had been committing my Drupal 5 updates up until I unassigned myself from this task. Please re-diff against the most recent CVS head version. I just committed the part of your patch by hand that updated some of the code formatting issues, but that's it.
Comment #17
mcarbone commentedMy apologies -- I'm still new to proper procedure. I patched against the latest 4.7 release. I'll upload a patch against HEAD later today.
Comment #18
mcarbone commentedOK, here's the new patch, diffed against the latest CVS HEAD.
One question: why does HEAD have all the admin functionality -- searching, ip banning, and blacklisting -- moved into admin/settings? That seems more confusing to me than the menu layout in the latest 4.7 release, which put them in the admin menu with local tabs. Now they're in the settings menu sans local tabs.
Comment #19
deekayen commentedIt doesn't make a difference to me. The night I did that I was under the impression the Drupal 5 admin navigation had moved more to the link tree block than in tabs, but since I can't really back that statement up with an example, you can put it back if you want. I'll tag this as ready to be committed until you either upload a tab version or give the go ahead to commit what you've uploaded so far.
Comment #20
mcarbone commentedWell, you're correct that Drupal 5 doesn't seem to have any admin menus directly underneath the Administer menu anymore. So I kept Troll under the "Site Configuration" area, but added tabs and added one for the options page to make it more usable. Patch attached.
Comment #21
mcarbone commentedSame thing, but I fixed some incorrect URLs.
Comment #22
deekayen commentedCommitted patch4 and branched to DRUPAL-5. I'm about to make a dev release on the Drupal project page. Make changes through a new issue.
Comment #23
(not verified) commented