Drupal 5.x port
bubbasan - January 17, 2007 - 07:37
| Project: | Worklog |
| Version: | HEAD |
| Component: | Code |
| Category: | feature request |
| Priority: | normal |
| Assigned: | Unassigned |
| Status: | needs work |
Description
I have begun the process of upgrading workflow to 5.0. Or has someone else already begun the conversion. I would be more then willing to help.
#1
I mean worklog
#2
If you've made any progress, submit a patch. I haven't started the worklog upgrade and I'm not sure when I'll have time.
#3
I think i have updated everything except for the views portion, but the blocks and create/edit node should work. Take a gander.
#4
worklog.install file
#5
worklog.info file
#6
Great work on the port. I am seeing a few errors when trying to create a worklog however:
warning: array_merge_recursive() [function.array-merge-recursive]: Argument #2 is not an array in /var/www/drupal/5.x/core/modules/node/node.module on line 1971.Also, the worklog option is not listed in the main page when I click on "Create content". This is a common porting problem to 5.x but I don't quite remember what the solution is.
I attach a patch that fixes a few issues with the install file:
#7
I'm also seeing those errors after enabling the blocks:
warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'worklog_start_form' was given in /var/www/drupal/5.x/core/includes/form.inc on line 217.warning: call_user_func_array() [function.call-user-func-array]: First argument is expected to be a valid callback, 'worklog_start_form' was given in /var/www/drupal/5.x/core/includes/form.inc on line 217.
Typing forms api porting problems. :)
#8
The module patch itself seems to work well, although it is bigger (!) than the file itself.. Breaking it into chunks in the attached file.
#9
just tracking this. I am going to try using this patch and see how well it works.
#10
anarcat,
When i try to patch the original worklog.module with your 5.x-port.patch I get like seven heap dumps.
The original worklog_0.patch then worked on the original worklog.module. Am I supposed to apply 5.x-port.patch to the already patched module?. . . I did this but got the following anyway.
warning: array_merge_recursive() [function.array-merge-recursive]: Argument #2 is not an array in /var/www/drupal/5.x/core/modules/node/node.module on line 1971.#11
Hmmm.... I'm sorry, it's been a while since I worked on this patch, and I didn't update it to follow -HEAD. The 5.x-port.patch looks like it's complementary to the worklog.install _0.patch, but I honestly don't remember. It sure looks like I did a little too big 5.x-port.patch, although the issue *is* still marked "code needs work". I just dumped the little work I did on the module here so that others can evolve from it. For example, in the last patch I proposed, the views is removed entirely (at first glance), which is of course undesirable on the long run.
I *think* the patch applies cumulatively with the others, but I keep on forgetting what the policy is on Drupal.org with regards to that, so I might messed up one way or the other...
I'm going on a vacation until aug. 15th, so I will not have time to work more on this, but it is very likely that Koumbit will need this module in the upcoming year, so I might work again on it soon enough. Maybe other koumbit workers will come and lurk here in replacement too. :)
#12
Subscribing to issue. If I have a hour of spare time, I'll see what I can do.
#13
I've done any work on worklog for drupal 5, because I use it only on my personal site, and it's still 4.7. Seeing this thread makes me think there is more interest in this module than I ever knew. I would welcome a patch that brings it up-to-date with drupal 5. Failing that, I will get around to it, but it's difficult to predict when (maybe within 2 weeks).
#14
It looks like xamox night be providing a more robust solution by extending the case tracker module,
He could probably use some help if you think it's the way to go?
Current status http://groups.drupal.org/node/5398
Original Proposal
http://xamox.net/drupal/proposal
#15
Subscribing.
I don't think Xamox's work ended up including a time tracker, and it still has to go through a process of being integrated with case tracker before it's released publicly, as far as I know.
So I think this module's still needed and I'd like to see how it could be used with case tracker (as extended by Xamox or not).
ben, Agaric Design Collective
#16
A Drupal 5 option with a different approach: http://drupal.org/project/node_time_tracker
Here's a dialogue between the authors of both modules.
#17
See also: http://drupal.org/project/timer
#18
subscribing