When submitting a node form with a multiselect element the widget got broken when the submission failed due to validation errors as the necessary css and js files were not included anymore. I moved the inclusion of these files from _multiselect_build_widget_code() to multiselect_field_widget_form() using the new D7 #attached key and that seems to fix the problem.

CommentFileSizeAuthor
#10 1101264.patch1.21 KBmagnusk
multiselect.module.patch1.23 KBpatrick r.

Comments

patrick r.’s picture

patrick r. commented
Title: Widget broken when » Widget broken when form validations fails
attheshow’s picture

attheshow commented
Status: Needs review » Postponed (maintainer needs more info)

I haven't been able to duplicate this. Please post steps to duplicate the problem. Simply submitting the form doesn't produce the bug mentioned above.

patrick r.’s picture

patrick r. commented

Well, unfortunately (?) I'm also not able to reproduce this behaviour except under the given circumstances. I have set up a rather complex content content type with lots of fields, fieldgroups and different widget types and when I submit the node form leaving some required fields blank the form shows up again with the usual error messages and the multiselect widget being unstyled and not functional (available options show up in both of the selects). Somehow the necessary css and js is not included in that specific case. I added a multiselect widget to another content type and the problem did not occur here. I guess it's not an obvious bug then if any. ;-) Nevertheless it might still not be a too bad idea to make use of this new #attached property, but I'll leave that up to you.

erlingx’s picture

erlingx commented

The bug showed up here. I've got a complex content type with different fields/widget types/ckEditor ...
The patch solved the issue :)

esculcar’s picture

esculcar commented
Version: 7.x-1.8 » 7.x-1.x-dev

I have same problem always, after save, when some field requiered or some condition is not satisfied.

slashrsm’s picture

slashrsm commented

Same thing as mentioned in #5 happens also to me. It can be reproduces if you open new node edit form and hit save immediately. Title is required by default, so it will not pass validation and reload form with broken multiselect widget.

paranojik’s picture

paranojik commented
Status: Postponed (maintainer needs more info) » Reviewed & tested by the community

The provided patch, apart from a small coding standard non-compliance, is OK. RTBC.

mrharolda’s picture

mrharolda commented

I have similar, but very different issue with form validation and multi_select: when submitting an existing node with a 'required field error', the multiselects will have their old values instead of the new values set with the edit.

Can anyone confirm this?

I tried the patch, but it doesn't fix this issue.

Babymaggie’s picture

Babymaggie commented

Hi guy's - Love the idea of this widget but Im suffering the same problem.

If you create a taxonomy field and then mark the field (let's say categories) as required, - If you then go to save your content without selecting a category then you will get the failure - I've tried both versions (dev and approved) for D7 and I'm getting the same problem.

I have attempted the patch, but not knowing what's going on I can't seem to get it to work.

Could someone kindly upload the file for me with the patch applied for me to try?

Many thanks

magnusk’s picture

magnusk commented
StatusFileSize
new 1101264.patch1.21 KB

I've encountered the same problem and agree that this is the right solution. (I've had similar issues when using drupal_add_css in custom D7 forms.)

Here is a proposed revision of the patch, more in line with the coding standard?

magnusk’s picture

magnusk commented
Status: Reviewed & tested by the community » Needs review
paranojik’s picture

paranojik commented
Status: Needs review » Reviewed & tested by the community

This patch is ready.

stijn.vanden.brande’s picture

stijn.vanden.brande commented

I encountered the same problem and tested the patch.
Patch works fine, RTBC.

Thanks

jvandooren’s picture

jvandooren commented

Same problem, used patch from #10 and problem fixed...

johnv’s picture

johnv
Primary language Dutch
commented

I confirm that the patch solves the problem.

johnv’s picture

johnv
Primary language Dutch
commented
Status: Reviewed & tested by the community » Needs work

IMO this patch is not complete until the issue from #6, #8 is resolved:

- Add/edit a node, where field 1 (or even Title) is required, and field 2 has the multiselect widget.
- clear field 1
- change the value(s) from field 2
- submit the form; the page is regenerated with an error "field is required."
- check field 2: it has the original values - this is not the case when using e.g. checkboxes

magnusk’s picture

magnusk commented
Status: Needs work » Reviewed & tested by the community

John, the loss of previously entered data is a separate issue. If there isn't one open (I mentioned one aspect of the problem in #1321664: User & node references don't load when editing an existing node), you should create one. This particular issue is about the wrong approach to attaching CSS/JS to the widget in the node form, and the patch fixes it.

rbishop’s picture

rbishop commented

thank you ! patch #10 worked perfectly for me (drupal 7.14/multiselect 7.x-1.9)

BeaPower’s picture

BeaPower commented

when will this be committed?

pierrepaul’s picture

pierrepaul commented

Tested patch in #10 and worked perfectly. Thanks!

alexweber’s picture

alexweber commented
Status: Reviewed & tested by the community » Fixed

Thanks all for the great work! This has been committed in 8eef5b6.

Status: Fixed » Closed (fixed)

Automatically closed -- issue fixed for 2 weeks with no activity.