Closed (fixed)
Project:
Views (for Drupal 7)
Version:
7.x-3.x-dev
Component:
Miscellaneous
Priority:
Normal
Category:
Task
Assigned:
Unassigned
Reporter:
Created:
22 Mar 2011 at 14:44 UTC
Updated:
4 Jun 2012 at 07:36 UTC
Jump to comment: Most recent file
Comments
Comment #1
merlinofchaos commentedThis seems reasonable and interesting. Moving ot an unassigned task; this means it is accepted as a feature we would use, but it needs a developer to take an interest in it to write the code to do it.
Comment #2
dawehnerWould be cool to get some feedback.
it worked fine for me, with quite a lot of created views.
Comment #3
dawehnerUpdated patch based on feedback of tobiasb
Comment #4
yched commented[edited out, I was totally on crack]
Comment #5
DjebbZ commentedI modified the patch so the new page appears directly under admin/reports. It was hidden under admin/reports/fields without a local task so even in this page you needed the core "Navigation" block to know this page existed.
Also added a few comments, pluralized some words, etc.
I'm wondering : as it's a new feature, where should it be documented ? d.o ? advanced help ? other place ? all of them ?
Comment #6
dawehnerI would say advanced help is the best place.
Thanks! for the better place in the menu, couldn't decide which one would be the best, so your solution works great.
Comment #7
DjebbZ commentedCan you give me a pointer on where/how to write this advanced help topic ? So I will write it and learn how to do this for future places in Views.
Comment #8
dawehnerIn general it's help part of views/help directory.
It seems to be that there doesn't exist a page on which information belongs, so you have to add one.
Therefore open help/views.help.ini
There you can add a new file
Once you did this you can add the file-name.html to the directory and write down the help/link.
If you need to link to another topic there is the useful shortcut:
Does this help you?
Comment #9
DjebbZ commentedYes, a lot !
Rerolled patch with a new adv. help page. What do you think ?
Edit : git rebase -i is super cool, as well as git commit --amend. Git is really wonderful...
And a question : I've formatted the patch with
git format-patch, so it will be attributed to me only, whereas you did most of the work. I realize it's unfair...Comment #10
dawehnerPersonally i think this kind of commits only work for one-man work. If there is more then one involved the classical "by foo, bar" is still effective. Regarding the commit itself, ... with this kind of patch you can still use patch -p1 < ... and the authorship informations got lost.
Are you sure you have the right patch attached? This one doesn't have something changed in the help.
Comment #11
DjebbZ commentedThanks for the clarification. It means you could remove the authorship information from the patch and still mention my name in the release notes. Noted.
Sorry for the patch, I misplayed with git, but it doesn't change the fact that Git rocks the VCS world.
Comment #12
dawehnerIt sure does. For example "cherry-pick" is crazy genious awesome. And awesome in real!
Just wondering whether it would make sense to bring the views-analyze drush commando to another page,
or make this availible as drush commando, nevermind that's just what i'm thinking.
Comment #13
DjebbZ commentedI'm reading
git help cherry-pick, and I get you... Really clever people behind this git thing...Sorry I don't get what you say : do you mean that we should create a new drush command from this, like
drush views-fields(alias vf could be good), or integrate the results in theviews-analysecommand ? Or something else ? I would create a new views-fields command. It could almost be called fields-views, because it's half views-related, half field-related. The current result in the UI looks like the coredrush field-infocommand, display info about fields (this is really whatdrush views-fieldscould be). So I think it shouldn't be mixed withdrush views-analyze, which is more about reporting problems with views.A note for johnv and anyone reading this issue : we cannot add a column "Used in Views", so we created a new report page for this purpose.
Comment #14
dawehnerlet's use a new issue for the drush task. Do you think it's helpful?
Thanks for helping here! Commited to 7.x-3.x.
Comment #15
johnv(removed, posted twice)
Comment #16
johnvI am glad my request is fullfilled. Thanks guys, it's a real help.
@dereine, however, the patch does not seem to be applied, as you stat in #14.
Version 7.x-3.x-dev of 2011-Aug-20 does not contain the patch, nor is it under 'View commits', both on the d.o. project page.
Comment #17
dawehnerForgot to push the changes.
Comment #18
DjebbZ commented@dereine : I'm all for a new issue to add the drush command. You're welcome for the help :)
@johnv : Happy to help you, as I really think it's helpful.
Comment #20
johnvI posted a follow-up here: #1615752: Better location for report 'Fields used in Views'