Can hardly wait for Drupal 5 port...

CommentFileSizeAuthor
#18 phpbb_v5.patch8.07 KBmaartenvg

Comments

secrets123’s picture

my vote too

NeoID’s picture

The same here, would love to see someone port this to 5.x. I use phpBB 2.x and it would be cool to be able to connect it to Drupal 5. :)

arkepp’s picture

I started on it, but had to push it aside. Too much to do right now, sorry.

It's not a hard thing to do, you just have to spend time reading how these forms are defined in Drupal right now. 90% of the code should still work.

arkepp’s picture

I started on it, but had to push it aside. Too much to do right now, sorry.

It's not a hard thing to do, you just have to spend time reading how the forms are defined in Drupal 5. 90% of the code should still work.

kreynen’s picture

With Drupal 5 released, would it make sense to focus on the beta of phpBB3? I've installed the phpBB3 beta and it seems work well for basic discussions. The interface and code changes put in more on par with Drupal 5. I'm not sure what is left or phpBB development team's checklist before they release get to a release canidate or a final release, but going from Drupal 5 with all it's JQeury niceties to phpBB2.x is almost like going back in time.

Has anyone looked at working on this from the other direction? Hacking phpBB to authenticate against Drupal's user table?

phpBB3 includes LDAP support. I thought maybe both systems could authenticate against an independent LDAP directory, but Drupal's LDAP module has lost it's maintainer as well.

It would be frustrating if anyone was being paid to do the work.

arkepp’s picture

I don't care much for LDAP in PHP, but it's not related to this module anyway, so it doesn't matter what I think.

I will release an update for 4.7.5 within the next couple of days if I can figure out the last bug. phpbb3 is a high priority, I need it for my sites, but the code is not ready yet and the phpbb team seems to be busy with other things than closing bugs.

Anyone with a bit of time can upgrade this module, that's the community component. I will wait for phpbb3 / drupal 4.7.5 for my own needs, and i'll move to drupal 5 after that.

Budrick’s picture

You won't update the module for Drupal 5 untill phpbb 3 is released, am I right?
And it can take a long time to wait for phpbb 3.
So, the sentence "In case anyone is wondering about Drupal 5.0: This module will be moved to Drupal 5.0 and phpBB 3 at the end of this year." in module description is in force for 2007?

arkepp’s picture

Sorry, that was written back in November (I think) when I had less on my plate and a lot of faith in phpBB 3. And to make it clear, I don't expect to wait until the end of 2008, I just don't know when I will get around to it. The problem is not as much to rewrite the code, but to maintain updates (I spent 10 hours this week on the 4.7 module, I'll commit to CVS soon) and to test the code afterwards. The latter part will be twice as intensive with two versions of the module.

As I am pointing out in more than one place, this module is not suitable for novices. Porting the code to 5.0 is relatively simple, just a bit tedious, and you need to test it thoroughly afterwards. If you are going to depend on this code for your website, writing a port should not be a major challenge. The quality, and possibly the usability, of this module is likely to improve a lot if there are more than four people who understand how it works. I'll be happy to answer specific questions or help debug the port.

ps. I retract what I said earlier about AcydBurn & Co. not working on phpBB3, I was looking at a cached statistics page that was not moving. This page show's they're making headway.

maartenvg’s picture

I've only recently found the wonders of Drupal, and am converting an entire community I maintain to Drupal. Problem is that we heavily depend on phpBB, therefore I need this a module to work with 5.x and phpBB.
I've already patched some other 4.7 modules to 5.x (although no extensive testing yet), so I would like to look into porting this one too.

I'm also looking for a project to put some time in (not that I have that much of it, but I like to contribute to one big thing instead of a lot of little contributions all over the place). As you said you would like it if there are more people with enough know-how of this module and phpBB to help out a hand.
While I'm at porting the code, I'll try to understand the code as much as possible and hopefully be able to assist you in maintaining this very important module. And of course help you add features and hopfully porting it to phpbb3 some day.

But for now, give me some time to catch up with the code and let's see if I can get a fully working 5.x version out of this as soon as possible.

arkepp’s picture

Excellent, feel free to contact me directly if you have questions :)

I assume you mean phpBB 2.x ? I have looked at phpBB 3.x (beta), which will unfortunately require a number of "real" changes, beyond switching to the 5.x Drupal API.

maartenvg’s picture

yup, I meant 2.x. :)

furmans’s picture

I'm also heavily dependent of phpBB 2.x and ready to migrate from Drupal 4.7 to 5.x. This week or next, I'm starting work on updating this module. If any of you have made progress, I'll look at it and help with coding, debugging, and testing. Feel free to contact me.

maartenvg’s picture

I'm still busy with it, but can't work on it now (birthday of my girlfriend, so my inlaws are coming over, you get the point ;)). I'll try to generate a patch to review/test it as soon as possible, somewhere this week. The problem at the moment is that the .htaccess for the phpbb-directory isn't working properly on my system (something to do with virtualdocumentroot I believe), so testing that functionality is lagging behind. The synchronisation works good, though.

arkepp’s picture

I don't think you have to worry about the .htaccess file, since phpBB hasn't changed.

It sends requests to drupal/phpbb , but you can test that without actually having the mod_rewrite working (just look at the file, the URLs are easy to understand). You're right that Virtual-anything is a likely culprit.

rubensans’s picture

I will also be very interested on that.

Best Regards.

kreynen’s picture

So now that phpBB3 has been released, any update on when we might seen the Drupal 5/phpBB3 version of this module. I've read the some users have gotten the current phpBB module to work with Drupal 5, but I have yet to see any code.

arkepp’s picture

I haven't seen any of that code either, so I can't tell you. My schedule is busy (grad student, I don't get to choose my own poison) until the end of next week. But we can branch the CVS and publish maartenvg's Drupal 5.0 / phpbb 2.x code as soon as he feels it's ready for public scrutiny.

phpBB 3 released? I agree it must be getting close (it took only 5 years hehe), but I think the new front page is confusing you.

maartenvg’s picture

Status: Active » Needs review
StatusFileSize
new8.07 KB

Here is my patch which works for me (but I left the .htaccess intact)
Have fun with it! :)

rubensans’s picture

How do you install this patch?

I'm working in a windows environement.

Best Regards.

Ruben.

NeoID’s picture

HOWTO: Apply patches
http://drupal.org/node/60108

arkepp’s picture

I put a pre-patched version here: http://kepp.net/phpbb.tar.gz

So far I must say it looks very good, you only forgot to give yourself some credit in the header ;) I'll try to make time to test it more tomorrow night.

If it works for you please post back here. If it doesn't, please create a new issue on the phpbb project. The instructions are long, so there's a good chance it's not due to the new code.

NeoID’s picture

I've added the module without any problems so far. Sessions are fine and everything seems to be working smoothly...
Keep up the good work, both of you :)

arkepp’s picture

Okay, I'm happy with it.

I'll fix the norwegian I forgot in the user profile, and I've updated the phpbb profile fields (optional) and added a ../ in the user profile.

If anyone wants to test, without installing, go here: http://kepp.net/drupal-5.1/

I only need to remember how to do branches in CVS, and maybe roll a release for 4.7 before we move on :)

arkepp’s picture

Assigned: Unassigned » arkepp
Status: Needs review » Fixed

Sorry about the slow response, I don't get much sleep these days ;)

I have attempted to create branches and releases in CVS / Drupal's system. Hopefully they will show up on the front page of the module within 12 hours, when the release-building script runs.

maartenvg: Thanks again :)

arkepp’s picture

Status: Fixed » Closed (fixed)